[OpenWrt-Devel] [PATCH 1/3] treewide: drop DEVICE_TYPE when used as device variable

[mail at adrianschmutzler.de]

> > > Or am I completely misled here?
> >
> > I believe you are right, it seems DEVICE_TYPE is not evaluated when
> > set in a device definition.
> True, question is then, should this really be called "DEVICE"_TYPE?
> It's not like other DEVICE_* variables (DEVICE_NAME, DEVICE_PACKAGES or
> DEVICE_DTS).
> Because the "targets" of ath79/ipq40xx/etc... wouldn't work if they all had to
> share a single, common DEVICE_NAME/_DTS/_PACKAGE.
> 
> As for the MBLs, if I got this all correctly, that DEVICE_TYPE could be simply
> moved to the apm821xx/sata target.mk
> ---
> --- a/target/linux/apm821xx/image/Makefile
> +++ b/target/linux/apm821xx/image/Makefile
> @@ -251,7 +251,6 @@ define Device/wd_mybooklive
>    DEVICE_VENDOR := Western Digital
>    DEVICE_MODEL := My Book Live Series (Single + Duo)
>    DEVICE_PACKAGES := kmod-usb-dwc2 kmod-usb-ledtrig-usbport kmod-
> usb-storage kmod-fs-vfat wpad-basic
> -  DEVICE_TYPE := nas
>    DEVICE_DTS := wd-mybooklive
>    SUPPORTED_DEVICES += mbl wd,mybooklive-duo
>    BLOCKSIZE := 1k
> --- a/target/linux/apm821xx/sata/target.mk
> +++ b/target/linux/apm821xx/sata/target.mk
> @@ -1,5 +1,6 @@
>  BOARDNAME := Devices which boot from SATA (NAS)  FEATURES += ext4
> usb ramdisk squashfs rootfs-part boot-part
> +DEVICE_TYPE := nas
>  DEFAULT_PACKAGES += badblocks block-mount e2fsprogs kmod-hwmon-
> drivetemp \
>  		    kmod-dm kmod-md-mod partx-utils mkf2fs f2fsck
> 
> ---
> And it would work as expected, right?
> 
> Cheers,
> Christian
> 

Yes, in this case this would work as expected after change. Of course, this assumes that future additions to the subtarget would be "NAS-devices" as well.

> True, question is then, should this really be called "DEVICE"_TYPE?

That's exactly the question we are discussing in 3/3 of this series which went to the openwrt-devel, I only Cc-ed you for the 1/3.

I personally tend towards dropping DEVICE_TYPE entirely and separate the selection of different subsets for DEFAULT_PACKAGES from providing a config option for packages like busybox.

I will convert my patch so your solution proposed here will be included.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200529/b6b00828/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel