[OpenWrt-Devel] [PATCH v2 1/1] firewall3: harden string functions that might overflow

Philip Prindeville philipp_subx at redfish-solutions.com
Fri May 15 19:59:31 EDT 2020


So that I may craft the rewrite appropriately, it would help to know what your objection to strlcpy() is.

Sent from my iPhone

> On May 14, 2020, at 7:24 PM, Philip Prindeville <philipp_subx at redfish-solutions.com> wrote:
> 
> What should I use instead of strlcpy or strcpy?
> 
> Sent from my iPhone
> 
>> On May 14, 2020, at 11:04 AM, Jo-Philipp Wich <jo at mein.io> wrote:
>> 
>> Hi,
>> 
>> the sprintf() to snprintf() changes are fine to me. Please omit the
>> conversions to strlcpy() and please don't use fmemopen().
>> 
>> ~ Jo
>> 
>> _______________________________________________
>> openwrt-devel mailing list
>> openwrt-devel at lists.openwrt.org
>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list