[OpenWrt-Devel] [PATCH v2 1/1] firewall3: harden string functions that might overflow

Jo-Philipp Wich jo at mein.io
Thu May 14 13:04:11 EDT 2020


Hi,

the sprintf() to snprintf() changes are fine to me. Please omit the
conversions to strlcpy() and please don't use fmemopen().

~ Jo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200514/f12d8eac/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list