[OpenWrt-Devel] [PATCH v2] wireguard-tools: fix version indicator

[Paul Fertser]

Hello,

I'm not talking about this specific patch but rather about the general
problem I'm aware of, in this specific case it might be not
applicable.

On Mon, May 11, 2020 at 04:25:42PM +0200, Petr Štetiar wrote:
> > If we execute `wg --version` we get a diffrent version string that does
> > not match with the version string in the openwrt makefile.
> >
> > Current version string:
> > `wireguard-tools vreboot-13159-gac5caa2718 -https://git.zx2c4.com/wireguard-tools/`

This is clearly the git tag from OpenWrt tree itself.

> ok, but I fail to see why this patch should be maintained by OpenWrt, this
> looks like it should be fixed upstream. Thanks.

Many projects when cloned from a git tree use some variation of "git
describe" to embed a meaningful version in the compiled
binary. OpenWrt kind of breaks the assumptions because it first does a
git clone but then packs an archive with all the sources but not the
.git directory. Of course it makes sense to save space on servers and
buildbots and whereever the downloads are stored. However, without
.git directory the command run by a particular build system will often
traverse to the upper directories until it finds the OpenWrt tree
.git.

Probably the right way to solve this would be to have means to
override the default git describe behaviour (and force specific
version string instead) by a configure (or similar) flag. That would
require collaboration with upstream but will also need some additional
tweaks to the OpenWrt package Makefile.

--
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel