[OpenWrt-Devel] Remove generic OpenWrt copyright spread through files

mail at adrianschmutzler.de mail at adrianschmutzler.de
Tue Mar 31 08:56:30 EDT 2020


Hi,

I frequently encounter files in the OpenWrt trunk (both Makefiles and files included in images) that contain "generic" Copyright information like:

#
# Copyright (C) 2014-2016 OpenWrt.org
# Copyright (C) 2016 LEDE-Project.org
#

By "generic", I'm referring to the fact that this claims OpenWrt copyright inside the OpenWrt projects code, which seems redundant to me.

Examples:
https://github.com/openwrt/openwrt/blob/master/package/system/opkg/Makefile
https://github.com/openwrt/openwrt/blob/master/target/linux/mvebu/cortexa72/base-files/etc/board.d/02_network

In the first example, a similar argument applies to the license, which is just a repetition of the repo's license.

I wonder whether it would be appropriate to remove these "redundant" Copyright/license comments. To me, it just looks like a waste of space (in case of the board.d file actually space on the device) where it is not really conveying any additional information.

As I'm a young member in development though, I'd like to have some opinions on this one before I do anything (including proposing a patch).

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200331/1c81d092/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list