[OpenWrt-Devel] [RFC PATCH] ath79: clarify purpose of factory image

[mail at adrianschmutzler.de]

Hi,

> > tftp.bin - can _not_ be used from vendor OS, but can be used via TFTP
> 
> The name "tftp-recovery" (maybe "tftp_recovery") has already seen some
> use on images built for the purposes of being used for TFTP, maybe it would
> be better to keep that naming?

It looks like tftp.bin is used for ath79 and tftp-recovery.bin is used for ramips, while the latter are a few more (see grep below).

I'd definitely have that unified, though I have a weak tendency towards the shorter version (tftp.bin). Maybe somebody else has a taste on this?

Best

Adrian

---

adsc at buildfff:/data/openwrt$ grep -rn "tftp.*\.bin" target/linux/ | sort
target/linux/ar71xx/image/legacy.mk:345:                ) > $(call imgname,$(1),$(2))-tftp.bin; \
target/linux/ar71xx/image/legacy.mk:375:                ) > $(call imgname,$(1),$(2))-tftp.bin; \
target/linux/ath79/image/generic.mk:1190:  IMAGES += tftp.bin
target/linux/ath79/image/generic.mk:1191:  IMAGE/tftp.bin := $$(IMAGE/sysupgrade.bin) | yuncore-tftp-header-16m
target/linux/ath79/image/generic.mk:1201:  IMAGES += tftp.bin
target/linux/ath79/image/generic.mk:1202:  IMAGE/tftp.bin := $$(IMAGE/sysupgrade.bin) | yuncore-tftp-header-16m
target/linux/ath79/image/generic.mk:1212:  IMAGES += tftp.bin
target/linux/ath79/image/generic.mk:1213:  IMAGE/tftp.bin := $$(IMAGE/sysupgrade.bin) | yuncore-tftp-header-16m
target/linux/ath79/image/generic.mk:201:  IMAGES += factory.bin tftp.bin
target/linux/ath79/image/generic.mk:206:  IMAGE/tftp.bin := $$(IMAGE/default) | buffalo-tftp-header
target/linux/ath79/image/generic.mk:224:  IMAGES += factory.bin tftp.bin
target/linux/ath79/image/generic.mk:229:  IMAGE/tftp.bin := $$(IMAGE/default) | buffalo-tftp-header
target/linux/ath79/image/generic.mk:243:  IMAGES += factory.bin tftp.bin
target/linux/ath79/image/generic.mk:248:  IMAGE/tftp.bin := $$(IMAGE/default) | buffalo-tftp-header
target/linux/ath79/image/generic.mk:259:  IMAGES += factory.bin tftp.bin
target/linux/ath79/image/generic.mk:264:  IMAGE/tftp.bin := $$(IMAGE/default) | buffalo-tftp-header
target/linux/ath79/image/tiny.mk:13:  IMAGE/tftp.bin := $$(IMAGE/default) | buffalo-tftp-header
target/linux/ath79/image/tiny.mk:8:  IMAGES += factory.bin tftp.bin
target/linux/layerscape/README:109:  => tftp a0000000 <firmware_name>-firmware.bin
target/linux/layerscape/README:123:  => tftp a0000000 <firmware_name>-firmware.bin
target/linux/layerscape/README:142:  => tftp 96000000 <firmware_name>-firmware.bin
target/linux/layerscape/README:78:  => tftp a0000000 <firmware_name>-firmware.bin
target/linux/layerscape/README:89:  => tftp a0000000 <firmware_name>-firmware.bin
target/linux/layerscape/README:99:  => tftp a0000000 <firmware_name>-firmware.bin
target/linux/ramips/image/mt76x8.mk:258:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:259:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:287:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:288:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:338:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:339:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:353:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:354:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:366:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:367:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:379:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:380:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:392:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:393:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:420:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:421:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:434:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:435:  IMAGE/tftp-recovery.bin := pad-extra 64k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:449:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:450:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/mt76x8.mk:465:  IMAGES := sysupgrade.bin tftp-recovery.bin
target/linux/ramips/image/mt76x8.mk:466:  IMAGE/tftp-recovery.bin := pad-extra 128k | $$(IMAGE/factory.bin)
target/linux/ramips/image/rt305x.mk:303:  IMAGES += tftp.bin
target/linux/ramips/image/rt305x.mk:304:  IMAGE/tftp.bin := $$(sysupgrade_bin) | check-size | \

-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200326/9c0aba9b/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel