[OpenWrt-Devel] [PATCH] target.mk: enable iwinfo by default with any wpad variant

[mail at adrianschmutzler.de]

Hi Piotr,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Piotr Dymacz
> Sent: Mittwoch, 25. März 2020 00:34
> To: openwrt-devel at lists.openwrt.org
> Subject: [OpenWrt-Devel] [PATCH] target.mk: enable iwinfo by default with
> any wpad variant
> 
> There are currently 7 variants of 'wpad' package but 'iwinfo' is included by
> default only if 'wpad', 'wpad-{basic,mini}' or 'nas'
> packages are included in {DEVICE,DEFAULT}_PACKAGES. Use 'wpad-*'
> pattern to include 'iwinfo' with any 'wpad' variant.
> 
> Signed-off-by: Piotr Dymacz <pepe2k at gmail.com>
> ---
>  include/target.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/target.mk b/include/target.mk index
> 9bd4c14936..004db1f45b 100644
> --- a/include/target.mk
> +++ b/include/target.mk
> @@ -55,7 +55,7 @@ endif
>  DEFAULT_PACKAGES += $(DEFAULT_PACKAGES.$(DEVICE_TYPE))
> 
>  filter_packages = $(filter-out -% $(patsubst -%,%,$(filter -%,$(1))),$(1)) -
> extra_packages = $(if $(filter wpad-mini wpad-basic wpad nas,$(1)),iwinfo)
> +extra_packages = $(if $(filter wpad wpad-% nas,$(1)),iwinfo)

Since you are touching this, maybe you can elaborate why this extra_packages construct is needed at all?

Why can't we just add iwinfo as selective dependency to the wpad-/nas packages as we do for all of the other packages?

I'm asking because I recently had a downstream case where we use hostapd instead of wpad and wanted to get of iwinfo.
I expected iwinfo to go away because nothing selected it anymore, but in this case it turned out that iwinfo is not automatically deselected, but has to be removed manually as well.

Best

Adrian

> 
>  define ProfileDefault
>    NAME:=
> --
> 2.20.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200325/87a52d1d/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel