[OpenWrt-Devel] [PATCH] busybox: fix build with musl 1.2.0

Rosen Penev rosenp at gmail.com
Tue Mar 24 23:03:14 EDT 2020


On Sun, Mar 22, 2020 at 2:25 PM Rosen Penev <rosenp at gmail.com> wrote:
>
> On Sun, Mar 22, 2020 at 7:45 AM Petr Štetiar <ynezz at true.cz> wrote:
> >
> > Rosen Penev <rosenp at gmail.com> [2020-03-20 16:45:06]:
> >
> > > The SYS_settimeofday is no longer present. That is, it's replaced with the
> > > time32 variant. There is no time64 variant.
> >
> > FYI upstream email "busybox 1.31.1 build issues with glibc-2.31 and musl
> > 1.2.0"[1] mentions other fixes as well. If more fixing is needed, it would be
> > nice to handle it via upstream first, thanks.>
> >
> > 1. http://lists.busybox.net/pipermail/busybox/2020-March/087843.html
> I looked into those. I did not need to backport these in order to get
> busybox to compile. I assume it would break under custom conditions.
>
> Note that the last patch adds a dependency on librt (part of libc for
> musl and uClibc-ng but not glibc).
>
> I think this patch is good enough for now.
Turns out, this breaks builds on uClibc-ng. Will roll a new version when I can.

I question what this patch is for. More details:
https://github.com/systemd/systemd/issues/13305#issuecomment-520463236

My reading of it is that it's there for kmod-fs-fat/udf/hfs compatibility.

It's also deprecated. Hence no time64 version.

Wonder if this patch should simply be removed.
> >
> > -- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list