[OpenWrt-Devel] RFT: Add support for kernel 5.4
Stefan Lippers-Hollmann
s.l-h at gmx.de
Mon Mar 9 19:16:55 EDT 2020
Hi
On 2020-03-09, Adrian Schmutzler wrote:
> > -----Original Message-----
> > From: Stefan Lippers-Hollmann [mailto:s.l-h at gmx.de]
[...]
> > On 2020-02-28, John Crispin wrote:
> > > On 28.02.20 21:30, Stefan Lippers-Hollmann wrote:
> > > > On 2020-02-28, mail at adrianschmutzler.de wrote:
> > > >>> On 2020-02-28, Koen Vandeputte wrote:
> > [...]
> > > > ath79 with kernel 4.14 has already been (mostly) broken by "ath79: add
> > > > new ar934x spi driver" (ebf0d8dadeca443121f4f597c51bf6591e341caf), which
> > > > does break the (shared between all kernel versions) DTS definitions for
> > > > NAND based ath79 devices (breaking compilation with kernel 4.14).
> > > >
> > > > Because of "FS#2524 - ath79-tiny: TP-Link TL-WR941ND v2.4: Marvel
> > > > MV88E6060 regression between kernel v4.14 and v4.19"
> > > > https://bugs.openwrt.org/index.php?do=details&task_id=2524 I still do
> > > > regularly build ath79 with kernel 4.14, but in order to finish the build
> > > > I do need to comment out the affected devices:
> > [...]
> > > >
> > > > Admittedly, the affected TL-WR941ND v2 (4/32) is barely worth the effort
> > > > anymore.
[...]
> > Neither, nor. It's merely a report that kernel 4.14 support (albeit
> > technically present in source) for ath79 isn't functional anymore (and
> > hasn't been for a few weeks) anyways, regardless of the introduction of
> > kernel 5.4 and its changes to ag71xx. Kind of answering Adrian's previous
> > question "By moving ag71xx to files-4.19 on ath79, I suspect 4.14 is broken
> > now on this target."
[...]
> thanks for you detailed explanation.
>
> Is there a specific reason why you build based on master and do not use the
> 19.07 stable branch with working 4.14 support?
[...]
As mentioned previously, the device in question isn't really in active
use anymore, I mostly do semi-regular regression testing with it.
Therefore my pain threshold for it is limited,
- enough to patch it back into the generic subtarget and build it (thanks
to TARGET_MULTI_PROFILE && TARGET_PER_DEVICE_ROOTFS) as part of the
build for actually useful devices,
- enough to rebase the patchset to bring it back into generic,
- enough to fix the build if the image got oversized again,
- enough to spend some efforts on debugging new issues,
but I probably wouldn't start a dedicated build just for this particular
device (as part of dedicated debugging, sure, but not regularly). If it
can't keep up with master builds, it's fate will be entertaining the dust
bunnies, before finally meeting its maker.
If this regression with ag71xx and Marvell MV88E6060 can't be fixed, it
would be better to stop generating images for this particular device, as
it's hard to recover. Therefore I'd suggest to add either of these
patches to master:
https://github.com/pkgadd/openwrt/commits/tl-wr941ndv2-deactivate
--
From 3aacb4b374ee76bf2b0d2e43fc450a6bab50ffd9 Mon Sep 17 00:00:00 2001
From: Stefan Lippers-Hollmann <s.l-h at gmx.de>
Date: Mon, 9 Mar 2020 23:56:34 +0100
Subject: [PATCH] ath79-tiny: disable image generation for the tl-wr941nd v2/
v3
Since kernel v4.19 support for the Marvell MV88E6060 switch used in
this devices has been broken, leading to an inaccesible device without
an enduser compatible recovery method (no push-button tftp recovery,
requiring serial console access and adding quite tiny 0-ohm SMD
resistors to fix the cut serial rx traces).
Disable image generation for this device until this gets fixed.
Signed-off-by: Stefan Lippers-Hollmann <s.l-h at gmx.de>
---
target/linux/ath79/image/tiny-tp-link.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/linux/ath79/image/tiny-tp-link.mk b/target/linux/ath79/image/tiny-tp-link.mk
index 29fdfec1e58..f0eaefbee41 100644
--- a/target/linux/ath79/image/tiny-tp-link.mk
+++ b/target/linux/ath79/image/tiny-tp-link.mk
@@ -338,7 +338,7 @@ define Device/tplink_tl-wr941-v2
TPLINK_HWID := 0x09410002
TPLINK_HWREV := 2
endef
-TARGET_DEVICES += tplink_tl-wr941-v2
+#TARGET_DEVICES += tplink_tl-wr941-v2
define Device/tplink_tl-wr941-v4
$(Device/tplink-4m)
--
or https://github.com/pkgadd/openwrt/commits/tl-wr941ndv2-nuke
--
From 8dbdd50dc732d429e4650d375b56fc72587c5f42 Mon Sep 17 00:00:00 2001
From: Stefan Lippers-Hollmann <s.l-h at gmx.de>
Date: Tue, 10 Mar 2020 00:05:16 +0100
Subject: [PATCH] ath79-tiny: drop support for the tl-wr941nd v2/ v3
Since kernel v4.19 support for the Marvell MV88E6060 switch used in
this devices has been broken, leading to an inaccesible device without
an enduser compatible recovery method (no push-button tftp recovery,
requiring serial console access and adding quite tiny 0-ohm SMD
resistors to fix the cut serial rx traces).
Drop support for this device.
Signed-off-by: Stefan Lippers-Hollmann <s.l-h at gmx.de>
---
.../ath79/dts/ar9132_tplink_tl-wr941-v2.dts | 168 ------------------
target/linux/ath79/image/tiny-tp-link.mk | 13 --
target/linux/ath79/tiny/config-default | 5 -
3 files changed, 186 deletions(-)
delete mode 100644 target/linux/ath79/dts/ar9132_tplink_tl-wr941-v2.dts
diff --git a/target/linux/ath79/dts/ar9132_tplink_tl-wr941-v2.dts b/target/linux/ath79/dts/ar9132_tplink_tl-wr941-v2.dts
deleted file mode 100644
index 1be4d6183ac..00000000000
--- a/target/linux/ath79/dts/ar9132_tplink_tl-wr941-v2.dts
+++ /dev/null
@@ -1,168 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/dts-v1/;
-
-#include <dt-bindings/gpio/gpio.h>
-#include <dt-bindings/input/input.h>
-
-#include "ar9132.dtsi"
-
-/ {
- compatible = "tplink,tl-wr941-v2", "qca,ar9132";
- model = "TP-Link TL-WR941N/ND v2/v3";
-
- aliases {
- led-boot = &led_system;
- led-failsafe = &led_system;
- led-running = &led_system;
- led-upgrade = &led_system;
- label-mac-device = ð0;
- };
-
- keys {
- compatible = "gpio-keys";
-
- reset {
- label = "reset";
- linux,code = <KEY_RESTART>;
- gpios = <&gpio 3 GPIO_ACTIVE_LOW>;
- debounce-interval = <60>;
- };
-
- qss {
- label = "qss";
- linux,code = <KEY_WPS_BUTTON>;
- gpios = <&gpio 7 GPIO_ACTIVE_LOW>;
- debounce-interval = <60>;
- };
- };
-
- leds {
- compatible = "gpio-leds";
-
- led_system: system {
- label = "tp-link:green:system";
- gpios = <&gpio 2 GPIO_ACTIVE_LOW>;
- };
-
- qss_r {
- label = "tp-link:red:qss";
- gpios = <&gpio 4 GPIO_ACTIVE_HIGH>;
- };
-
- qss_g {
- label = "tp-link:green:qss";
- gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
- };
-
- wlan {
- label = "tp-link:green:wlan";
- gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
- linux,default-trigger = "phy0tpt";
- };
- };
-
- dsa {
- compatible = "marvell,dsa";
- #address-cells = <1>;
- #size-cells = <0>;
-
- dsa,mii-bus = <&mdio0>;
- dsa,ethernet = <ð0>;
-
- switch at 0 {
- #address-cells = <1>;
- #size-cells = <0>;
- reg = <0>;
-
- port at 0 {
- reg = <0>;
- label = "wan";
- };
-
- port at 1 {
- reg = <1>;
- label = "lan1";
- };
-
- port at 2 {
- reg = <2>;
- label = "lan2";
- };
-
- port at 3 {
- reg = <3>;
- label = "lan3";
- };
-
- port at 4 {
- reg = <4>;
- label = "lan4";
- };
-
- port at 5 {
- reg = <5>;
- label = "cpu";
- };
- };
- };
-};
-
-&uart {
- status = "okay";
-};
-
-&spi {
- status = "okay";
-
- flash at 0 {
- compatible = "jedec,spi-nor";
- reg = <0>;
- spi-max-frequency = <25000000>;
-
- partitions {
- compatible = "fixed-partitions";
- #address-cells = <1>;
- #size-cells = <1>;
-
- uboot: partition at 0 {
- label = "u-boot";
- reg = <0x000000 0x20000>;
- read-only;
- };
-
- partition at 20000 {
- compatible = "tplink,firmware";
- label = "firmware";
- reg = <0x020000 0x3d0000>;
- };
-
- art: partition at 3f0000 {
- label = "art";
- reg = <0x3f0000 0x10000>;
- read-only;
- };
- };
- };
-};
-
-&mdio0 {
- status = "okay";
-};
-
-ð0 {
- status = "okay";
-
- phy-mode = "rmii";
- mtd-mac-address = <&uboot 0x1fc00>;
-
- fixed-link {
- speed = <100>;
- full-duplex;
- };
-};
-
-&wmac {
- status = "okay";
- mtd-cal-data = <&art 0x1000>;
- mtd-mac-address = <&uboot 0x1fc00>;
-};
diff --git a/target/linux/ath79/image/tiny-tp-link.mk b/target/linux/ath79/image/tiny-tp-link.mk
index 29fdfec1e58..3428e5c11db 100644
--- a/target/linux/ath79/image/tiny-tp-link.mk
+++ b/target/linux/ath79/image/tiny-tp-link.mk
@@ -327,19 +327,6 @@ define Device/tplink_tl-wr940n-v6
endef
TARGET_DEVICES += tplink_tl-wr940n-v6
-define Device/tplink_tl-wr941-v2
- $(Device/tplink-4m)
- SOC := ar9132
- DEVICE_MODEL := TL-WR941ND
- DEVICE_VARIANT := v2/v3
- DEVICE_ALT0_VENDOR := TP-Link
- DEVICE_ALT0_MODEL := TL-WR941N
- DEVICE_ALT0_VARIANT := v2/v3
- TPLINK_HWID := 0x09410002
- TPLINK_HWREV := 2
-endef
-TARGET_DEVICES += tplink_tl-wr941-v2
-
define Device/tplink_tl-wr941-v4
$(Device/tplink-4m)
SOC := ar7240
diff --git a/target/linux/ath79/tiny/config-default b/target/linux/ath79/tiny/config-default
index 42243cfc481..9b8ed872a2b 100644
--- a/target/linux/ath79/tiny/config-default
+++ b/target/linux/ath79/tiny/config-default
@@ -1,11 +1,6 @@
CONFIG_LEDS_RESET=y
CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=y
CONFIG_NET_DEVLINK=y
-CONFIG_NET_DSA=y
-CONFIG_NET_DSA_MV88E6060=y
-# CONFIG_NET_DSA_TAG_QCA is not set
-CONFIG_NET_DSA_TAG_TRAILER=y
-CONFIG_NET_SWITCHDEV=y
CONFIG_PHYLINK=y
CONFIG_PHY_AR7100_USB=y
CONFIG_PHY_AR7200_USB=y
--
Regards
Stefan Lippers-Hollmann
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200310/681c5607/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list