[OpenWrt-Devel] [PATCH] exfat-nofuse: fix kernel 5.4 compilation issue

[mail at adrianschmutzler.de]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Stefan Lippers-Hollmann
> Sent: Samstag, 7. März 2020 01:32
> To: Rosen Penev <rosenp at gmail.com>
> Cc: Paul Blazejowski <paulb at blazebox.homeip.net>; OpenWrt Development
> List <openwrt-devel at lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] [PATCH] exfat-nofuse: fix kernel 5.4
> compilation issue
> 
> Hi
> 
> On 2020-03-06, Rosen Penev wrote:
> > On Fri, Mar 6, 2020 at 11:38 AM Paul Blazejowski
> > <paulb at blazebox.homeip.net> wrote:
> [...]
> > > -   DEPENDS:=+kmod-nls-base
> > > +   DEPENDS:=+kmod-nls-base @(LINUX_4_14||LINUX_4_19)
> > I prefer @!LINUX_5_4
> 
> Using @!LINUX_5_4 would break, once the next kernel after 5.4 comes
> around (be it in semi-private testing or officially with the next LTS kernel),
> while it's safe to assume that no older kernels will be merged back into
> master. It's usually a better strategy to test for known old kernels/ features,
> than to consider the new approach as an exception.

I see it similarly, using older kernels for selection will make the code base more future-proof.

Despite, it is also easier to adjust dependencies if an old kernel is removed.

Best

Adrian 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200307/7ad285c8/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel