[OpenWrt-Devel] [PATCH] malta: fix missing watchdog dependency in hwmon-sch5627

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Yousong Zhou
> Sent: Donnerstag, 5. März 2020 12:57
> To: Petr Štetiar <ynezz at true.cz>
> Cc: OpenWrt Development List <openwrt-devel at lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] [PATCH] malta: fix missing watchdog
> dependency in hwmon-sch5627
> 
> On Thu, 5 Mar 2020 at 19:46, Petr Štetiar <ynezz at true.cz> wrote:
> >
> > Fixes following error uncovered while building malta/be on 5.4:
> >
> >  Package kmod-hwmon-sch5627 is missing dependencies for the following
> libraries:
> >  watchdog.ko
> >
> > That dependency was introduced in upstream via 2d8c7ff52c24
> > ("hwmon/sch56xx: Depend on watchdog for watchdog core functions") in
> > v3.5.
> 
> Does it make we actually package watchdog.ko as a module?  Lots of targets
> already set it as builtin, but I do not remember ever interacting with it directly
> on ar71xx, ramips.

Well, ar71xx obviously won't matter in master, so I'd say just ignore this case.

Best

Adrian

> 
> Regards,
>                 yousong
> 
> >
> > Cc: Yousong Zhou <yszhou4tech at gmail.com>
> > Signed-off-by: Petr Štetiar <ynezz at true.cz>
> > ---
> >  target/linux/malta/config-4.19 | 1 +
> >  target/linux/malta/config-5.4  | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/target/linux/malta/config-4.19
> > b/target/linux/malta/config-4.19 index f66036e27bb7..3ad7dbed7558
> > 100644
> > --- a/target/linux/malta/config-4.19
> > +++ b/target/linux/malta/config-4.19
> > @@ -333,4 +333,5 @@ CONFIG_VT=y
> >  CONFIG_VT_CONSOLE=y
> >  CONFIG_VT_HW_CONSOLE_BINDING=y
> >  CONFIG_VXFS_FS=y
> > +CONFIG_WATCHDOG_CORE=y
> >  CONFIG_XPS=y
> > diff --git a/target/linux/malta/config-5.4
> > b/target/linux/malta/config-5.4 index 41fc9770435f..37d3dbef9ae0
> > 100644
> > --- a/target/linux/malta/config-5.4
> > +++ b/target/linux/malta/config-5.4
> > @@ -341,4 +341,5 @@ CONFIG_VT=y
> >  CONFIG_VT_CONSOLE=y
> >  CONFIG_VT_HW_CONSOLE_BINDING=y
> >  CONFIG_VXFS_FS=y
> > +CONFIG_WATCHDOG_CORE=y
> >  CONFIG_XPS=y
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel