[OpenWrt-Devel] Security implications for consideration [Was: Re: [openwrt/openwrt] rpcd: add respawn param]

[Florian Eckert]

>> > > procd_open_instance
>> > > procd_set_param command "$PROG" ${socket:+-s "$socket"}
>> > > ${timeout:+-t "$timeout"}
>> > > + procd_set_param respawn ${respawn_retry:-0}
>> > >
>> >
>> > IMHO this is probably not correct as well, that respawn param is
>> > "array" of
>> > [threshold, timeout, retry] params, so this probably sets
>> > `respawn_threshold` to
>> > 0, not `respawn_retry` as intended.
>> >
>> 
>> I was not aware of the fact that all parameters must be given!
>> Sorry for that my fault!
>> 
>> If so I would suggest to change change the line to:
>> 
>> procd_set_param respawn ${respawn_threshold:-3600} 
>> ${respawn_timeout:-5}
>> ${respawn_retry:-5}
> 
> I barely remember seeing such defaults in
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=package/system/procd/files/procd.sh;h=e8b1b6ffb7d3bf09725c2451813ca69fb4d74372;hb=HEAD#l395
> 

So we only have to change the line to this?

procd_set_param respawn

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel