[OpenWrt-Devel] [PATCH] imx6: add support for Gateworks GW5907/GW5910/GW5912/GW5913

Tim Harvey tharvey at gateworks.com
Mon Mar 2 11:56:35 EST 2020


On Mon, Mar 2, 2020 at 8:53 AM Tim Harvey <tharvey at gateworks.com> wrote:
>
> On Sun, Mar 1, 2020 at 3:02 AM Adrian Schmutzler
> <mail at adrianschmutzler.de> wrote:
> >
> > Hi,
> >
> > > --- a/target/linux/imx6/base-files/etc/board.d/02_network
> > > +++ b/target/linux/imx6/base-files/etc/board.d/02_network
> > > @@ -13,7 +13,11 @@ case "$board" in
> > >  cubox-i |\
> > >  *gw51xx |\
> > >  *gw52xx |\
> > > -*gw5904)
> > > +*gw5904 |\
> > > +*gw5907 |\
> > > +*gw5910 |\
> > > +*gw5912 |\
> > > +*gw5913)
> >
> > Is there any actual need for the wildcards here? Shouldn't just gw5912,
> > gw5913 etc. be enough?
> >
>
> Adrian,
>
> Doesn't look like it... probably something that used to matter if
> board names used to have imx6q vs imx6dl but they clearly don't
> anymore.
>
> I will re-submit.
>

Adrian,

Actually, it may look cleaner if this patch is accepted and I
follow-up with one that removes the unnecessary wildcards as they have
been there for a while for other board models.

Any other issues with the original patch?

Tim

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list