[OpenWrt-Devel] [PATCH] Do not hard-code IS_TTY in script scripts/feeds

Kevin 'ldir' Darbyshire-Bryant ldir at darbyshire-bryant.me.uk
Sat Jun 6 11:45:25 EDT 2020


> From: "R. Diez" <rdiezmail-openwrt at yahoo.com>
> Subject: Re: [OpenWrt-Devel] [PATCH] Do not hard-code IS_TTY in script scripts/feeds
> Date: 6 June 2020 at 13:44:11 BST
> To: Petr Štetiar <ynezz at true.cz>
> Cc: openwrt-devel at lists.openwrt.org
> 
> 
> 
>> https://openwrt.org/submitting-patches#no_mime_no_links_no_compression_no_attachments_just_plain_text
> 
> Sometimes I use Thunderbird, and sometimes I use the Yahoo web interface. Both have problems with e-mail formatting, as they tend to reflow text lines and mess with quotations and blanks. Sending patches as plain text inside e-mails is too much trouble for me.
> 
> I do not understand why Patchwork cannot automatically pick up a patch from an e-mail attachment aptly named xxx.patch, and with an e-mail title that starts with [PATCH].
> 
> Is it possible to add patches manually to Patchwork using its web interface? If so, I would try that way.
> 
> Otherwise, I am tempted to drop it (and other such further contributions I had in the pipeline). This is a trivial fix and the administrative cost of getting it right is clearly disproportionate.

I recognise the frustration!  When I first started trying to send patches I had similar issues (white space wrapping/reflow etc)  The same issues are encountered when sending to many open source email patch lists including the Linux kernel.  I came very, very, very close to giving up with openwrt, before being introduced to ‘git send-email’.  I fought a little with configuring git send-email and got it working, before I then discovered https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/  which is a quite helpful guide. Maybe that can help you too?

Kevin
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list