[PATCH 2/2] build: image: return sizes if check-size fails

[Paul Spooren]

Is there an easy way to test this? As in, how do I force the Kernel to 
be to big?

On 29.07.20 09:00, Adrian Schmutzler wrote:
> Instead of just printing a warning that an image is too big, also
> print both actual size and limit in the string:
>
> WARNING: Image file somename.bin is too big: 2096101 > 1048576
>
> Since the kernel size is checked via the same function (if
> KERNEL_SIZE is specified), this will also apply to the kernel
> image size check.
>
> Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> ---
>   include/image-commands.mk | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/include/image-commands.mk b/include/image-commands.mk
> index 97a66dce30..811edba994 100644
> --- a/include/image-commands.mk
> +++ b/include/image-commands.mk
> @@ -269,8 +269,10 @@ define Build/xor-image
>   endef
>   
>   define Build/check-size
> -	@[ $$(($(subst k,* 1024,$(subst m, * 1024k,$(if $(1),$(1),$(IMAGE_SIZE)))))) -ge "$$(stat -c%s $@)" ] || { \
> -		echo "WARNING: Image file $@ is too big" >&2; \
> +	@imagesize="$$(stat -c%s $@)"; \
> +	limitsize="$$(($(subst k,* 1024,$(subst m, * 1024k,$(if $(1),$(1),$(IMAGE_SIZE))))))"; \
> +	[ $$limitsize -ge $$imagesize ] || { \
> +		echo "WARNING: Image file $@ is too big: $$imagesize > $$limitsize" >&2; \
>   		rm -f $@; \
>   	}
>   endef