[PATCH 4/4] lantiq: disable default build for devices with 4M flash

Paul Spooren mail at aparcar.org
Sat Jul 25 17:42:41 EDT 2020


On 25.07.20 11:21, mail at adrianschmutzler.de wrote:
>> -----Original Message-----
>> From: Paul Spooren [mailto:mail at aparcar.org]
>> Sent: Samstag, 25. Juli 2020 23:19
>> To: Adrian Schmutzler <freifunk at adrianschmutzler.de>; openwrt-
>> devel at lists.openwrt.org
>> Subject: Re: [PATCH 4/4] lantiq: disable default build for devices with 4M
>> flash
>>
>> On 25.07.20 08:29, Adrian Schmutzler wrote:
>>> It has been decided that the 19.07 release will be last one to include
>>> 4/32 devices.
>>>
>>> This disables default build for all devices with 4M flash on lantiq.
>>> Note that this will affect _all_ devices for amazonse ("ase") and
>>> xway_legacy subtarget.
>> Isn't it cleaner to add the "source-only" feature to xway_legacy/target.mk
>> and ase/target.mk? Or is it device specific because new devices for either
>> subtarget are expected?
> I'm not sure what source-only exactly does. I'll look it up.
>
> The aim is that users are still able to build those devices with adjusted settings, both with imagebuilder and make menuconfig, at least in principle.

The buildbot schedules builds on the targets determined via 
dumpinf.pl[0][1]. If a target/subtarget contains source-only it won't 
appear in the list.

As a consequence neither toolchain, ImageBuilder nor SDK are build.

[0]: 
https://patchwork.ozlabs.org/project/openwrt/patch/20200713031629.1716736-1-mail@aparcar.org/
[1]: 
https://git.openwrt.org/?p=buildbot.git;a=blob;f=phase1/master.cfg;h=792f9b3a55a2d8ebae1917c56716cc0d699f9172;hb=HEAD#l180

> Best
>
> Adrian
>
>>> Signed-off-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
>>>
>>> ---
>>>
>>> As this will effectively empty ase und xway_legacy subtarget, we
>>> essentially can disable the buildbots on master for those right away.
>>> ---
>>>    target/linux/lantiq/image/amazonse.mk    | 4 +++-
>>>    target/linux/lantiq/image/danube.mk      | 3 +++
>>>    target/linux/lantiq/image/falcon.mk      | 2 ++
>>>    target/linux/lantiq/image/xway_legacy.mk | 5 +++++
>>>    4 files changed, 13 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/target/linux/lantiq/image/amazonse.mk
>>> b/target/linux/lantiq/image/amazonse.mk
>>> index 4a23a68e40..1fd714dee4 100644
>>> --- a/target/linux/lantiq/image/amazonse.mk
>>> +++ b/target/linux/lantiq/image/amazonse.mk
>>> @@ -5,16 +5,18 @@ define Device/allnet_all0333cj
>>>      DEVICE_PACKAGES := kmod-ltq-adsl-ase kmod-ltq-adsl-ase-mei \
>>>    	kmod-ltq-adsl-ase-fw-b kmod-ltq-atm-ase \
>>>    	ltq-adsl-app ppp-mod-pppoe
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += allnet_all0333cj
>>>
>>>    define Device/netgear_dgn1000b
>>>      DEVICE_VENDOR := NETGEAR
>>>      DEVICE_MODEL := DGN1000B
>>> -  IMAGE_SIZE := 6000k
>>> +  IMAGE_SIZE := 3712k
>>>      DEVICE_PACKAGES := kmod-ltq-adsl-ase kmod-ltq-adsl-ase-mei \
>>>    	kmod-ltq-adsl-ase-fw-b kmod-ltq-atm-ase \
>>>    	ltq-adsl-app ppp-mod-pppoe
>>>      SUPPORTED_DEVICES += DGN1000B
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += netgear_dgn1000b
>>> diff --git a/target/linux/lantiq/image/danube.mk
>>> b/target/linux/lantiq/image/danube.mk
>>> index 2fb5ea061f..6ba9a91fb2 100644
>>> --- a/target/linux/lantiq/image/danube.mk
>>> +++ b/target/linux/lantiq/image/danube.mk
>>> @@ -29,6 +29,7 @@ define Device/arcadyan_arv4519pw
>>>    	kmod-ltq-adsl-danube-fw-a kmod-ltq-atm-danube \
>>>    	ltq-adsl-app ppp-mod-pppoa
>>>      SUPPORTED_DEVICES += ARV4519PW
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv4519pw
>>>
>>> @@ -110,6 +111,7 @@ define Device/arcadyan_arv7525pw
>>>    	kmod-ltq-adsl-danube-fw-b kmod-ltq-atm-danube \
>>>    	ltq-adsl-app ppp-mod-pppoa -swconfig
>>>      SUPPORTED_DEVICES += ARV4510PW
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv7525pw
>>>
>>> @@ -201,6 +203,7 @@ define Device/lantiq_easy50712
>>>      DEVICE_MODEL := Danube (EASY50712)
>>>      SOC := danube
>>>      IMAGE_SIZE := 3776k
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += lantiq_easy50712
>>>
>>> diff --git a/target/linux/lantiq/image/falcon.mk
>>> b/target/linux/lantiq/image/falcon.mk
>>> index a5490f6e68..6269cf6858 100644
>>> --- a/target/linux/lantiq/image/falcon.mk
>>> +++ b/target/linux/lantiq/image/falcon.mk
>>> @@ -57,6 +57,7 @@ define Device/lantiq_easy98000-nand
>>>      DEVICE_VARIANT := NAND
>>>      IMAGE_SIZE := 3904k
>>>      DEVICE_PACKAGES := kmod-dm9000 kmod-i2c-lantiq kmod-eeprom-at24
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += lantiq_easy98000-nand
>>>
>>> @@ -66,6 +67,7 @@ define Device/lantiq_easy98000-nor
>>>      DEVICE_VARIANT := NOR
>>>      IMAGE_SIZE := 3904k
>>>      DEVICE_PACKAGES := kmod-dm9000 kmod-i2c-lantiq kmod-eeprom-at24
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += lantiq_easy98000-nor
>>>
>>> diff --git a/target/linux/lantiq/image/xway_legacy.mk
>>> b/target/linux/lantiq/image/xway_legacy.mk
>>> index 52a29ab2f0..2eaefd2cdd 100644
>>> --- a/target/linux/lantiq/image/xway_legacy.mk
>>> +++ b/target/linux/lantiq/image/xway_legacy.mk
>>> @@ -8,6 +8,7 @@ define Device/arcadyan_arv4518pwr01
>>>    	ltq-adsl-app ppp-mod-pppoa \
>>>    	kmod-ath5k wpad-mini
>>>      SUPPORTED_DEVICES += ARV4518PWR01
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv4518pwr01
>>>
>>> @@ -21,6 +22,7 @@ define Device/arcadyan_arv4518pwr01a
>>>    	ltq-adsl-app ppp-mod-pppoa \
>>>    	kmod-ath5k wpad-basic
>>>      SUPPORTED_DEVICES += ARV4518PWR01A
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv4518pwr01a
>>>
>>> @@ -38,6 +40,7 @@ define Device/arcadyan_arv4520pw
>>>    	ltq-adsl-app ppp-mod-pppoa \
>>>    	kmod-rt61-pci wpad-mini
>>>      SUPPORTED_DEVICES += ARV4520PW
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv4520pw
>>>
>>> @@ -53,6 +56,7 @@ define Device/arcadyan_arv4525pw
>>>    	kmod-ltq-adsl-danube-fw-b kmod-ltq-atm-danube \
>>>    	ltq-adsl-app ppp-mod-pppoa -swconfig
>>>      SUPPORTED_DEVICES += ARV4525PW
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv4525pw
>>>
>>> @@ -68,5 +72,6 @@ define Device/arcadyan_arv452cqw
>>>    	kmod-ltq-adsl-danube-fw-b kmod-ltq-atm-danube \
>>>    	ltq-adsl-app ppp-mod-pppoa
>>>      SUPPORTED_DEVICES += ARV452CQW
>>> +  DEFAULT := n
>>>    endef
>>>    TARGET_DEVICES += arcadyan_arv452cqw



More information about the openwrt-devel mailing list