[PATCH v2] zram-swap: explicitely use mkswap/swapon/swapoff from /sbin

Rui Salvaterra rsalvaterra at gmail.com
Fri Jul 24 12:03:51 EDT 2020


Hi, Henrique,

On Fri, 24 Jul 2020 at 16:51, Henrique de Moraes Holschuh
<henrique at nic.br> wrote:
>
> Hmm, why not fix this for *good* and not depend on they being enabled in
> busybox "by default"?
>
> I'd just depend on the required busybox features and applets explicitly
> (or select them) *on top of what your patch already does*.
>
> While depends and selects are not always effective for busybox features,
> it *is* the proper build-time machine-readable documentation of the
> package requirements...  And it does work for anyone doing full builds.

Seems like a fine suggestion! I'll send an amended patch soon.

Thanks,
Rui



More information about the openwrt-devel mailing list