[PATCH] zram-swap: drop the conditional dependency on swap-utils

Rui Salvaterra rsalvaterra at gmail.com
Tue Jul 14 11:27:25 EDT 2020


The original idea was to pull-in swap-utils when the required BusyBox utilities
were unavailable. However, this made the zram-swap package strictly depend on
swap-utils when using the image builder, which is incorrect. Moreover,
swap-utils dropped the swapon/swapoff utilities years ago.

Let's just drop this dependency. BusyBox in the official builds includes the
required applets. I believe it's safe to assume people doing their own builds
and customising the configuration of BusyBox know what they're doing, since no
other package verifies and/or depends on specific BUSYBOX_* symbols.

Signed-off-by: Rui Salvaterra <rsalvaterra at gmail.com>
---
 package/system/zram-swap/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/system/zram-swap/Makefile b/package/system/zram-swap/Makefile
index a6661ce5e9..0d809c10e4 100644
--- a/package/system/zram-swap/Makefile
+++ b/package/system/zram-swap/Makefile
@@ -18,7 +18,7 @@ include $(INCLUDE_DIR)/package.mk
 define Package/zram-swap
   SECTION:=utils
   CATEGORY:=Base system
-  DEPENDS:=+kmod-zram +!(BUSYBOX_CONFIG_MKSWAP&&BUSYBOX_CONFIG_SWAPON&&BUSYBOX_CONFIG_SWAPOFF):swap-utils
+  DEPENDS:=+kmod-zram
   TITLE:=ZRAM swap scripts
   PKGARCH:=all
 endef
-- 
2.27.0




More information about the openwrt-devel mailing list