[OpenWrt-Devel] [PATCH 4/8] mvebu: image: keep global DTS_DIR intact

[Adrian Schmutzler]

> Ok, will send this as part of v2.

I will mark 3/8 as rejected.

I'd merge 1, 2 and 4 tomorrow or on Sunday, so if you want to wait for additional input on 5-8 you can also only send the former as smaller v2 patchset.

Best

Adrian

> 
> Regards
> 
> >
> >>
> >>> DEVICE_DTS_DIR and DTS_DIR might behave differently
> >>> when it comes to includes in DTS files.
> >>> That's why I couldn't replace SUNXI_DTS_DIR with DEVICE_DTS_DIR when
> >> touching
> >>> this some months ago.
> >>
> >> The issue might stem from DEVICE_VARS defined inside the profile, which
> might
> >> be exported too late? I'm not so good at Makefile syntax so maybe others can
> >> comment on that.
> >
> > For sunxi, no. There the problem is that DEVICE_DTS_DIR is present in
> conditions in image.mk (or one of those files), and the device setup in sunxi itself
> assumes that subdirs are part of DEVICE_DTS. But this effectively might be a
> separate issue, as it is connected to the setup in sunxi.
> > It's not easy to fix that in a proper way.
> >
> > Best
> >
> > Adrian
> >
> >>
> >>>
> >>> Best
> >>>
> >>> Adrian
> >>
> >> Regards
> >>
> >>>
> >>>>
> >>>> Signed-off-by: Tomasz Maciej Nowak <tomek_n at o2.pl>
> >>>> ---
> >>>>  target/linux/mvebu/image/Makefile | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/target/linux/mvebu/image/Makefile
> >>>> b/target/linux/mvebu/image/Makefile
> >>>> index d9e4b1acce..ae4d3b9594 100644
> >>>> --- a/target/linux/mvebu/image/Makefile
> >>>> +++ b/target/linux/mvebu/image/Makefile
> >>>> @@ -91,7 +91,7 @@ endef
> >>>>
> >>>>  define Device/Default-arm64
> >>>>    BOOT_SCRIPT := generic-arm64
> >>>> -  DTS_DIR := $(DTS_DIR)/marvell
> >>>> +  DEVICE_DTS_DIR := $(DTS_DIR)/marvell
> >>>>    IMAGES := sdcard.img.gz
> >>>>    IMAGE/sdcard.img.gz := boot-scr | boot-img-ext4 | sdcard-img-ext4 | gzip
> |
> >>>> append-metadata
> >>>>    KERNEL_NAME := Image
> >>>> --
> >>>> 2.25.0
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> openwrt-devel mailing list
> >>>> openwrt-devel at lists.openwrt.org
> >>>> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >>>
> >>
> >>
> >> --
> >> TMN
> >
> 
> 
> --
> TMN


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel