[OpenWrt-Devel] [PATCH procd 2/2] state: fix reboot causing shutdown inside LXC container

[Petr Štetiar]

On January 23, 2020 1:04:16 PM UTC, Paul Oranje <por at oranjevos.nl> wrote:

>Suggestion: log of this unexpected condition or even stronger, an
>assert().

All logging is killed already, logging just to serial console won't cut it, assert is overkill, which needs compiler flags/ifdef fiddling and who knows how that would behave in different environments.

I could split it into separate functions if that implicit return would be more acceptable for you. It just seems overkill to me, just to make both of us satisfied :-)

>Decorating perform_halt() with the _Noreturn function specifier might

Ok, I like this one.


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel