[OpenWrt-Devel] [PATCH v2] fstools: Add support to read-only MTD partitions (eg. recovery images)

Petr Štetiar ynezz at true.cz
Tue Jan 21 13:57:16 EST 2020


Bruno Pena <brunompena at gmail.com> [2020-01-21 14:53:54]:

Hi,

> Based on the last comment from Steve (fstools patch was not reverted), I'm
> not sure if that's the root cause.

you need to find out, but that Daniel's remark seems legit to me, your patch
likely changed the mtd device open order/flags.

> The kernel patch (which when reverted makes rootfs_data writable again)
> only enforces the parent mtd access mode on the sub-partitions.

FYI I currently dont have time to fix that regression myself and since its
likely affecting a lot of users, so I've reverted those changes. I think, that
this change is useful, so I'm still willing to merge it once fixed, no
worries. Having some upstream feedback beforehand would be a plus.

BTW it would be fair to inform upstream about this possible issue as well, so
the patch wont get merged in its current state, unless its double checked (or
just write them, that you're planning v2, so the patch is removed from their
Patchwork).

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list