[OpenWrt-Devel] [PATCH 2/7] base-files/functions.sh: use grep -q instead of []
Adrian Schmutzler
mail at adrianschmutzler.de
Fri Jan 17 06:04:47 EST 2020
Hi,
> - [ -z "$(echo $grp | cut -d: -f4 | grep $2)" ] || return
> - [ -n "$(echo $grp | grep ":$")" ] && delim=""
> + echo "$grp" | cut -d: -f4 | grep -q $2 || return
> + echo "$grp" | grep -q ":$" || delim=""
logic (&& ||) seems to be inverted here.
Just send the fixed one as standalone patch, I will merge it then.
Best
Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200117/0a16f43d/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
More information about the openwrt-devel
mailing list