[OpenWrt-Devel] [PATCH 3/3] ath79: add support for Teltonika RUT955

[Adrian Schmutzler]

Hi,

> > > +
> > > +		led_system_green: system_green {
> > > +			label = "rut955:green:system";
> > > +			gpios = <&gpio_ext 6 GPIO_ACTIVE_HIGH>;
> > > +			default-state = "on";
> > > +			linux,default-trigger = "phy0tpt";
> >
> > tpt trigger to the system LED? Don't think that would be really helpful,
maybe
> > one can use one of the signal leds for that?
> 
> This is how the vendor firmware handles it as well and there is a
> Wifi-symbol next to that LED. The signal bars are supposedly intended
> for the GSM/WCDMA/LTE WWAN signal strength.
> 

Okay. But the name/label should somehow indicate that, so it doesn't look like a
mistake.

If there is a WiFi symbol next to the LED, I'd actually consider renaming it to
"wifi" or "wlan", though.

Best

Adrian


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel