[OpenWrt-Devel] [netifd][PATCH] interface-ip: transfer prefix route ownership to kernel when IPv6 address becomes deprecated

[Adrian Schmutzler]

Hi,

please use a "v2" next time.

Best

Adrian

> -----Original Message-----
> From: Alin Năstac [mailto:alin.nastac at gmail.com]
> Sent: Mittwoch, 5. Februar 2020 14:38
> To: Adrian Schmutzler <mail at adrianschmutzler.de>
> Cc: Hans Dedecker <dedeckeh at gmail.com>; openwrt-devel <openwrt-
> devel at lists.openwrt.org>
> Subject: Re: [OpenWrt-Devel] [netifd][PATCH] interface-ip: transfer prefix route
> ownership to kernel when IPv6 address becomes deprecated
> 
> Hi Adrian,
> 
> This patch has been superseded by
> https://patchwork.ozlabs.org/patch/1233845/
> 
> Alin
> 
> On Wed, Feb 5, 2020 at 1:56 PM Adrian Schmutzler
> <mail at adrianschmutzler.de> wrote:
> >
> > Hi,
> >
> > works for me as well.
> >
> > However, I'd prefer a shorter commit title, e.g.
> >
> > interface-ip: transfer prefix route ownership for deprecated ipv6addr to kernel
> >
> > Best
> >
> > Adrian
> >
> > > -----Original Message-----
> > > From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org] On
> > > Behalf Of Alin Nastac
> > > Sent: Mittwoch, 5. Februar 2020 09:34
> > > To: Hans Dedecker <dedeckeh at gmail.com>
> > > Cc: openwrt-devel <openwrt-devel at lists.openwrt.org>
> > > Subject: Re: [OpenWrt-Devel] [netifd][PATCH] interface-ip: transfer prefix
> > route
> > > ownership to kernel when IPv6 address becomes deprecated
> > >
> > > Hi Hans,
> > >
> > > On Tue, Feb 4, 2020 at 10:49 PM Hans Dedecker <dedeckeh at gmail.com>
> wrote:
> > > >
> > > > Hi Alin,
> > > > On Mon, Feb 3, 2020 at 4:27 PM Alin Nastac <alin.nastac at gmail.com>
> wrote:
> > > > >
> > > > > From: Alin Nastac <alin.nastac at gmail.com>
> > > > >
> > > > > When netifd manages the prefix route directly, it will remove it
> > > > > the moment prefix gets deprecated. This will make it impossible
> > > > > for the target to send ICMPv6 errors back to LAN devices still
> > > > > using the deprecated prefix, thus breaking the L-14 requirement
> > > > > of RFC 7084.
> > > > >
> > > > > Signed-off-by: Alin Nastac <alin.nastac at gmail.com>
> > > > The patch fails to apply with the following error message :
> > > >
> > > > Applying: interface-ip: transfer prefix route ownership to kernel when
> > > > IPv6 address becomes deprecated
> > > > error: sha1 information is lacking or useless (interface-ip.c).
> > > > error: could not build fake ancestor
> > > > Patch failed at 0001 interface-ip: transfer prefix route ownership to
> > > > kernel when IPv6 address becomes deprecated
> > > >
> > > > >                         route.addr = addr.addr;
> > > > >                 }
> > > > >
> > > > > +               addr.flags |= DEVADDR_OFFLINK;
> > > > >                 if (system_add_address(l3_downlink, &addr))
> > > > >                         return;
> > > > >
> > > > > --
> > > > > 2.7.4
> > > > >
> > >
> > > I've downloaded the patch from
> > > https://patchwork.ozlabs.org/patch/1232885/ and applied it
> > > successfully with a git am command line:
> > >
> > > nastaca at cplx1037:/usr/localdisk/openwrt/netifd$ git am
> > > ~/Downloads/OpenWrt-Devel-netifd-interface-ip-transfer-prefix-route-
> > > ownership-to-kernel-when-IPv6-address-becomes
> > > -deprecated.patch
> > > Applying: interface-ip: transfer prefix route ownership to kernel when
> > > IPv6 address becomes deprecated
> > >
> > > Alin
> > >
> > > _______________________________________________
> > > openwrt-devel mailing list
> > > openwrt-devel at lists.openwrt.org
> > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel
> >


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel