Please revert 98b86296e6 as it breaks several ipq806x devices

Adrian Schmutzler mail at adrianschmutzler.de
Mon Dec 28 09:27:27 EST 2020


> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Hannu Nyman
> Sent: Montag, 28. Dezember 2020 10:12
> To: OpenWrt Development List <openwrt-devel at lists.openwrt.org>
> Cc: Petr Štetiar <ynezz at true.cz>; Christian Lamparter
> <chunkeey at gmail.com>
> Subject: Please revert 98b86296e6 as it breaks several ipq806x devices

https://github.com/openwrt/openwrt/commit/57e4cc8261ca6f0b32e4da6922a8f52ef82c4dc6

This is meant as an emergency measure (thus no "Fixes"), and should be properly addressed at some point.

Best

Adrian

> 
> Please revert commit 98b86296e6 "ipq806x: add support for ASRock G10" as
> it breaks several popular ipq806x devices.
> 
> 98b86296e6 adds a new kernel config symbol CONFIG_CMDLINE_OVERRIDE
> for ipq806x and enables it for all ipq806x devices.
> 
> Based on forum discussion and my own experience, that new symbol
> apparently changes the kernel command line and breaks several ipq806x
> devices. Either the devices do not boot or there are other symptoms.
> 
> 
> Symptoms in my own R7800:
> 
> * serial console is disabled. It works during u-boot but is silent after kernel
> takes over  (as console gets assigned to wrong tty)
> 
> * sysupgrade FROM builds with commit 98b86296e6 included does not work.
> Debugging that is not feasible, as serial console is broken...
> 
> 
> 
> Bug report in:
> 
> https://bugs.openwrt.org/index.php?do=details&task_id=3540
> 
> and in
> 
> https://github.com/openwrt/openwrt/commit/98b86296e67dd2b467212fe1
> a577656e6d3725da#commitcomment-45455875
> 
> 
> Things get fixed by reverting the kernel symbol part from 98b86296e6:
> 
> 
> |--- a/target/linux/ipq806x/config-5.4 +++
> |b/target/linux/ipq806x/config-5.4
> @@ -78,7 +78,7 @@ CONFIG_CC_HAS_KASAN_GENERIC=y
> CONFIG_CLKDEV_LOOKUP=y CONFIG_CLKSRC_QCOM=y
> CONFIG_CLONE_BACKWARDS=y -CONFIG_CMDLINE_OVERRIDE=y +#
> CONFIG_CMDLINE_OVERRIDE is not set CONFIG_COMMON_CLK=y
> CONFIG_COMMON_CLK_QCOM=y CONFIG_COMPAT_32BIT_TIME=y|
> 
> 
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201228/1f68cf79/attachment.sig>


More information about the openwrt-devel mailing list