[PATCH] build/prereq: requie make 4.1 or later

[Adrian Schmutzler]

Hi,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul Spooren
> Sent: Sonntag, 13. Dezember 2020 08:17
> To: openwrt-devel at lists.openwrt.org
> Cc: Paul Spooren <mail at aparcar.org>
> Subject: [PATCH] build/prereq: requie make 4.1 or later

there is a typo in the title.

Best

Adrian

> 
> FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of
> stdout piping to a file. The issue describes how e.g. terminal color codes and
> up in log files if running make like `make > log.txt`.
> 
> The proposed solution uses the make variable "MAKE_TERMOUT", which
> was introduced in make 4.1. All major distributions seem to updated to 4.1 or
> later, so this ideally dosn't break anything.
> 
> Signed-off-by: Paul Spooren <mail at aparcar.org>
> ---
>  include/prereq-build.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/prereq-build.mk b/include/prereq-build.mk index
> 5045fabdfb..ad204e95e8 100644
> --- a/include/prereq-build.mk
> +++ b/include/prereq-build.mk
> @@ -14,8 +14,8 @@ PKG_NAME:=Build dependency
> 
>  # Required for the toolchain
>  $(eval $(call TestHostCommand,working-make, \
> -	Please install GNU make v3.82 or later. (This version has bugs), \
> -	$(MAKE) -v | grep -E 'Make (3\.8[2-9]|3\.9[0-9]|[4-9]\.)'))
> +	Please install GNU make v4.1 or later., \
> +	$(MAKE) -v | grep -E 'Make (4\.[1-9]|[5-9]\.)'))
> 
>  $(eval $(call TestHostCommand,case-sensitive-fs, \
>  	OpenWrt can only be built on a case-sensitive filesystem, \
> --
> 2.29.2
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.openwrt.org/pipermail/openwrt-devel/attachments/20201213/4c2068bc/attachment.sig>