[PATCH] options: fix parsing of boolean attributes

Henrique de Moraes Holschuh henrique at nic.br
Thu Aug 20 08:47:44 EDT 2020


On 19/08/2020 21:34, Rémi NGUYEN VAN wrote:
> I see this is getting mixed with other patches, so to be clear this is
> a patch for firewall3 (see
> https://bugs.openwrt.org/index.php?do=details&task_id=3284).
> Let me know if there is a better place to post this.

Use "[PATCH] fw3: <rest of subject line>" (or "firewall3: ...") as the 
subject when sending the patch, and try to ensure the firewall3 
maintainers, if any, are copied (email CC).  You get that information 
from previous patches to firewall3 (look at the commit logs in git that 
touch the firewall3 directories) and from firewall3's OpenWrt Makefile.

That enhances the selected visibility of the patch to the people who 
would act on it faster.  It is also the best-practice on most of the 
FLOSS codebases that are complex enough to have several maintainers, 
subsystems, or components (examples are "git" itself, the Linux kernel, 
and OpenWrt :-) ).

Also, since there is a bug report open about it, it is a good idea to 
attach the patch there.  This helps ensure it won't be lost, although 
hopefully it will be acted upon soon enough.

Please consider re-sending the patch with the subject line change I 
suggested (and the extra CCs to firewall3 maintainers) if nobody replies 
to you about it in the next two or three days.

-- 
Henrique de Moraes Holschuh
www.nic.br



More information about the openwrt-devel mailing list