[OpenWrt-Devel] [PATCH v2 07/14] ath79/mikrotik: don't use mtd-mac-address in DTS

[Thibaut]

Hi,

> Le 20 avr. 2020 à 15:58, <mail at adrianschmutzler.de> <mail at adrianschmutzler.de> a écrit :
> 
> Hi,
> 
>> 
>> diff --git a/target/linux/ath79/mikrotik/base-files/etc/board.d/02_network
>> b/target/linux/ath79/mikrotik/base-files/etc/board.d/02_network
>> index ee795c7496..20c670f702 100755
>> --- a/target/linux/ath79/mikrotik/base-files/etc/board.d/02_network
>> +++ b/target/linux/ath79/mikrotik/base-files/etc/board.d/02_network
>> @@ -21,8 +21,15 @@ ath79_setup_interfaces()
>> ath79_setup_macs()
>> {
>> 	local board="$1"
>> +	local lan_mac=""
>> +	local wan_mac=""
>> +	local mac_base="/sys/firmware/mikrotik/hard_config/mac_base"
> 
> One of the concepts I tried to maintain for this section has been to always deal with MAC addresses directly (and not other types of data, like a path in this case).
> Thus, I'd prefer to have
> 
> local mac_base="$(cat /sys/firmware/mikrotik/hard_config/mac_base)"
> 
> and
> 
> lan_mac="$mac_base"
> ...
> 
> Despite, we save one cat ...
> 
> Despite that, you removed the label-mac-device above, so one should add it as label_mac here.

OK, will fix right away.

Thanks,
Thibaut
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel