[OpenWrt-Devel] [PATCH v2] phase1: Add JSON merging step

Paul Spooren mail at aparcar.org
Wed Apr 8 16:25:52 EDT 2020


On Wed, 2020-04-08 at 21:09 +0200, Petr Štetiar wrote:
> Paul Spooren <mail at aparcar.org> [2020-04-08 08:57:13]:
> 
> > v2:
> >   * Removed the `haltOnFailure` options as this may break the
> > current
> >     builds if the merge script show any unexpected errors in the
> > buildbot
> >     environment. This option should be added again once the script
> > proofs
> >     working.
> 
> Crash early, crash often. We've spent additional time to make the
> pipeline
> fail at every single step, now you're going to disable it? Why? Did
> you
> witnessed some breakage?

I now found another issue for "legacy" images which is fixed via

	[PATCH] scripts: JSON merge don't crash if no JSON found

> 
> From my point of view it doesnt make sense and its waste of time.

True
> 
> -- ynezz
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list