[OpenWrt-Devel] [PATCH 1/3] ramips: mt7621: add LAN port mac address to rbm11g dts

[mail at adrianschmutzler.de]

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Tobias Schramm
> Sent: Mittwoch, 8. April 2020 15:37
> To: mail at adrianschmutzler.de
> Cc: 'Thibaut' <hacks at slashdirt.org>; openwrt-devel at lists.openwrt.org;
> 'Chuanhong Guo' <gch981213 at gmail.com>
> Subject: Re: [OpenWrt-Devel] [PATCH 1/3] ramips: mt7621: add LAN port
> mac address to rbm11g dts
> 
> Hi Adrian,
> 
> >>  		port at 0 {
> >>  			status = "okay";
> >>  			label = "lan";
> >> +			mtd-mac-address = <&hard_config 0x0010>;
> >> +			mtd-mac-address-increment = <2>;
> >
> > That doesn't make sense to me.
> >
> > gmac0 is configured to 0x10 +1, why would you overwrite that value for a
> single port?
> Thanks for the clarification. Didn't look at the device hierarchy beforehand.

So you don't intend to change that anymore and I can mark the patch as rejected?

> >
> > And which is the correct value for the port of this device (based on vendor
> FW?).
> >
> > Note that setting another MAC address for the first port of m33g is because
> this is the WAN port, all LAN port will get the address from gmac0 there as
> well.
> >
> > Best
> >
> > Adrian
> 
> Tobias
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200408/3d13e9ff/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel