[OpenWrt-Devel] [PATCH 1/3] ramips: mt7621: add LAN port mac address to rbm11g dts

[mail at adrianschmutzler.de]

Hi Tobias,

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Tobias Schramm
> Sent: Mittwoch, 8. April 2020 12:47
> To: Chuanhong Guo <gch981213 at gmail.com>
> Cc: Thibaut <hacks at slashdirt.org>; openwrt-devel at lists.openwrt.org; Tobias
> Schramm <t.schramm at manjaro.org>
> Subject: [OpenWrt-Devel] [PATCH 1/3] ramips: mt7621: add LAN port mac
> address to rbm11g dts
> 
> This commit adds a mac address from the hard_config partition to LAN port
> of rbm11g.
> 
> Signed-off-by: Tobias Schramm <t.schramm at manjaro.org>
> ---
>  target/linux/ramips/dts/mt7621_mikrotik_rbm11g.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/linux/ramips/dts/mt7621_mikrotik_rbm11g.dts
> b/target/linux/ramips/dts/mt7621_mikrotik_rbm11g.dts
> index bcfce33a16..554573f30e 100644
> --- a/target/linux/ramips/dts/mt7621_mikrotik_rbm11g.dts
> +++ b/target/linux/ramips/dts/mt7621_mikrotik_rbm11g.dts
> @@ -149,6 +149,8 @@
>  		port at 0 {
>  			status = "okay";
>  			label = "lan";
> +			mtd-mac-address = <&hard_config 0x0010>;
> +			mtd-mac-address-increment = <2>;

That doesn't make sense to me.

gmac0 is configured to 0x10 +1, why would you overwrite that value for a single port?

And which is the correct value for the port of this device (based on vendor FW?).

Note that setting another MAC address for the first port of m33g is because this is the WAN port, all LAN port will get the address from gmac0 there as well.

Best

Adrian

>  		};
>  	};
>  };
> --
> 2.26.0
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200408/99f7c9c5/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel