[OpenWrt-Devel] [PATCH] ramips: use full 8MB flash on ZyXEL Keenetic

[mail at adrianschmutzler.de]

Hi,

> -----Original Message-----
> From: Alexey Dobrovolskiy [mailto:dobrovolskiy.alexey at gmail.com]
> Sent: Dienstag, 7. April 2020 20:51
> To: mail at adrianschmutzler.de
> Cc: openwrt-devel at lists.openwrt.org
> Subject: Re: [PATCH] ramips: use full 8MB flash on ZyXEL Keenetic
> 
> Hi Adrian,
> 
> thanks for you review.
> 
> > But I still wonder how this device is now supported for almost three years
> now and nobody mentioned that so far?
> The problem has already been described in bugreport FS#2487 [1].
> So i should also add
> Fixes: FS#2487

Yes.

> 
> > Do you have further evidence?
> WikiDevi page [2] says that ZyXEL Keenetic has FLA1: 8 MiB, there are some
> articles with specs [3], [4] (in Russian).
> I own this device and tested the patch before sending.
> I filed a bugreport FS#2964 [5] about another problem with ZyXEL Keenetic,
> there you may find bootlogs with this patch applied.
> If it is not enough, i can cite more internet forum posts about this problem.
> What of these should i add into commit description?

I'd add references [2] and [4] (the latter because of the nice pictures).

> 
> > Despite, if this is merged, somebody should add
> >
> > Fixes: a7cbf59e0e04 ("ramips: add new device ZyXEL Keenetic as kn")
> 
> I'll add.

Just add those pieces of information, resubmit and I will merge it.
Don't invest to much work in it, it's fine and I just wanted to have a little bit more of evidence.

Best

Adrian

> 
> [1] https://bugs.openwrt.org/index.php?do=details&task_id=2487
> [2] https://wikidevi.wi-cat.ru/ZyXEL_Keenetic
> [3] https://www.ixbt.com/comm/zyxel-keenetic.shtml
> [4] https://3dnews.ru/608774/page-2.html
> [5] https://bugs.openwrt.org/index.php?do=details&task_id=2964
> 
> Best regards,
> Alexey
> 
> пн, 6 апр. 2020 г. в 22:58, <mail at adrianschmutzler.de>:
> >
> > Hi Alexey,
> >
> > this patch is obviously correct in its implementation.
> >
> > But I still wonder how this device is now supported for almost three years
> now and nobody mentioned that so far?
> >
> > Do you have further evidence?
> >
> > Interestingly, I just found that the initial support commit even mentions
> "Flash: 8 MiB". But this could also be an error in the commit message.
> >
> > Despite, if this is merged, somebody should add
> >
> > Fixes: a7cbf59e0e04 ("ramips: add new device ZyXEL Keenetic as kn")
> >
> > Best
> >
> > Adrian
> >
> > > -----Original Message-----
> > > From: Alexey Dobrovolsky [mailto:dobrovolskiy.alexey at gmail.com]
> > > Sent: Donnerstag, 26. März 2020 20:11
> > > To: mail at adrianschmutzler.de
> > > Cc: Alexey Dobrovolsky <dobrovolskiy.alexey at gmail.com>; openwrt-
> > > devel at lists.openwrt.org
> > > Subject: [PATCH] ramips: use full 8MB flash on ZyXEL Keenetic
> > >
> > > ZyXEL Keenetic has 8MB flash, but OpenWrt uses only 4MB.
> > > This commit fixes the problem.
> > >
> > > Signed-off-by: Alexey Dobrovolsky <dobrovolskiy.alexey at gmail.com>
> > > ---
> > >  target/linux/ramips/dts/rt3052_zyxel_keenetic.dts | 2 +-
> > >  target/linux/ramips/image/rt305x.mk               | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> > > b/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> > > index ad641f47e4..436743cff3 100644
> > > --- a/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> > > +++ b/target/linux/ramips/dts/rt3052_zyxel_keenetic.dts
> > > @@ -48,7 +48,7 @@
> > >                       partition at 50000 {
> > >                               compatible = "denx,uimage";
> > >                               label = "firmware";
> > > -                             reg = <0x50000 0x3b0000>;
> > > +                             reg = <0x50000 0x7b0000>;
> > >                       };
> > >               };
> > >       };
> > > diff --git a/target/linux/ramips/image/rt305x.mk
> > > b/target/linux/ramips/image/rt305x.mk
> > > index 33f94edf3f..313c3fa315 100644
> > > --- a/target/linux/ramips/image/rt305x.mk
> > > +++ b/target/linux/ramips/image/rt305x.mk
> > > @@ -1149,7 +1149,7 @@ TARGET_DEVICES += zorlik_zl5900v2  define
> > > Device/zyxel_keenetic
> > >    SOC := rt3052
> > >    BLOCKSIZE := 64k
> > > -  IMAGE_SIZE := 3776k
> > > +  IMAGE_SIZE := 7872k
> > >    DEVICE_VENDOR := ZyXEL
> > >    DEVICE_MODEL := Keenetic
> > >    DEVICE_PACKAGES := kmod-usb2 kmod-usb-ehci kmod-usb-ledtrig-
> > > usbport
> > > --
> > > 2.17.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20200407/f0e5fda1/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel