[OpenWrt-Devel] [PATCH] ipq806x: remove unsupported hw-crypto qce driver

[Eneas U de Queiroz]

The following symbols, selected by the qce driver were removed:
	CONFIG_CRYPTO_CBC
	CONFIG_CRYPTO_CTR
	CONFIG_CRYPTO_DES
	CONFIG_CRYPTO_DEV_QCE
	CONFIG_CRYPTO_ECB
	CONFIG_CRYPTO_NULL
	CONFIG_CRYPTO_SEQIV
	CONFIG_CRYPTO_XTS

CONFIG_CRYPTO_GF128MUL was removed as well, since it is only needed by
some cipher modes (LRW, GCM), none of which are selected, and it is
packaged as a module.

Signed-off-by: Eneas U de Queiroz <cotequeiroz at gmail.com>

--

> The upstream qce crypto driver does not support the IPQ806x series.
> The ipq806x target used to host ipq40xx, so this driver was enabled as
> builtin back then.
> But since ipq40xx moved out, it's has become a symbol of "hope"....
> That maybe some day
> the NSS support of the IPQ806x can make use of it....
>
> So yeah, if you want to crush the hopes and dreams of the IPQ806X users,
> you can disable/remove the driver for the ipq806x target.
>
> Regards,
> Christian

My intention is not to "crush the hopes", but to avoid the frustration
when you find out something you thought was there not exist.

I did not remove CONFIG_CRYPTO_AEAD because it is already selected by
CONFIG_CRYPTO_PCRYPT=y in target/linux/generic/config-4.*, although I'm
not sure if I should not have dropped it anyway--it won't fail if I do.

Here is a dependency tree, showing only the removed symbols:

-CRYPTO_DEV_QCE
 \-CRYPTO_DES
 \-CRYPTO_ECB
 \-CRYPTO_CBC
 \-CRYPTO_XTS
 \-CRYPTO_CTR
   \-CRYPTO_SEQIV
     \-CRYPTO_AEAD*
     \-CRYPTO_NULL

Eneas

diff --git a/target/linux/ipq806x/config-4.14 b/target/linux/ipq806x/config-4.14
index 30736ae14e..38f5c94507 100644
--- a/target/linux/ipq806x/config-4.14
+++ b/target/linux/ipq806x/config-4.14
@@ -112,16 +112,10 @@ CONFIG_CRC16=y
 CONFIG_CRC32_SLICEBY8=y
 CONFIG_CRYPTO_AEAD=y
 CONFIG_CRYPTO_AEAD2=y
-CONFIG_CRYPTO_CBC=y
-CONFIG_CRYPTO_CTR=y
 CONFIG_CRYPTO_DEFLATE=y
-CONFIG_CRYPTO_DES=y
-CONFIG_CRYPTO_DEV_QCE=y
 CONFIG_CRYPTO_DRBG=y
 CONFIG_CRYPTO_DRBG_HMAC=y
 CONFIG_CRYPTO_DRBG_MENU=y
-CONFIG_CRYPTO_ECB=y
-CONFIG_CRYPTO_GF128MUL=y
 CONFIG_CRYPTO_HASH=y
 CONFIG_CRYPTO_HASH2=y
 CONFIG_CRYPTO_HMAC=y
@@ -130,15 +124,12 @@ CONFIG_CRYPTO_JITTERENTROPY=y
 CONFIG_CRYPTO_LZO=y
 CONFIG_CRYPTO_MANAGER=y
 CONFIG_CRYPTO_MANAGER2=y
-CONFIG_CRYPTO_NULL=y
 CONFIG_CRYPTO_NULL2=y
 CONFIG_CRYPTO_RNG=y
 CONFIG_CRYPTO_RNG2=y
 CONFIG_CRYPTO_RNG_DEFAULT=y
-CONFIG_CRYPTO_SEQIV=y
 CONFIG_CRYPTO_SHA256=y
 CONFIG_CRYPTO_WORKQUEUE=y
-CONFIG_CRYPTO_XTS=y
 CONFIG_DCACHE_WORD_ACCESS=y
 CONFIG_DEBUG_GPIO=y
 # CONFIG_DEBUG_UART_8250 is not set

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel