[OpenWrt-Devel] [PATCH v2] build: fix make kernel_menuconfig

Petr Štetiar ynezz at true.cz
Tue Sep 24 16:41:51 EDT 2019


Eneas Queiroz <cotequeiroz at gmail.com> [2019-09-24 17:06:28]:

Hi,

> The problem is that when scripts/config/lxdialog/check-lxdialog.sh is run,
> it will still use the staging_dir/host/bin/pkg-config script without
> STAGING_PREFIX set.

it doesn't work like that here, I've just added following into check-lxdialog.sh:

  echo "$(command -v pkg-config)" > $TOPDIR/meh.log

and meh.log contains /usr/bin/pkg-config after kernel_menuconfig run.

> > +DISTRO_PKG_CONFIG:=$(shell which -a pkg-config | grep -E '\/usr' | head -n 1)
> If we export this, then we can check its existence in
> tools/pkg-config/files/pkg-config, and decide which pkg-config we want
> to run.

if I understand it correctly this global exports are not welcome.

> Then, we can use the variable in our pkg-config script to decide what
> to run, using just pkg-config.real as a fallback if nothing is defined
> (alternatively, we can fail instead):

similar approach was already suggested[1] by Thomas originally and was considered
brittle (and I agreed with that), so I've reworked it to current version.

1. https://patchwork.ozlabs.org/patch/1163120/

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list