[OpenWrt-Devel] [PATCH] ath79: add support for TP-Link TL-MR6400

[Enrico Mioso]

Hello all,
thand thank you very very much for your kind help, and patience.
Adrian, you're a tireless reviewer, and to you my gratitude.
To you filip as well - very much thank you for your insight, I'll do the testing of the different ports ASAP!! :)
Dear Piotr,
I added you in CC since you developed the U-Boot replacement for this device, so I would like you to test the final patch to be sure we don't break things!

I am composing this message from scratch, since excessive quoting doesn't help readability for me. Sorry for the confusion.


Adrian wrote:
> Here, you assign eth1 to the "wan" LED, but in 02_network you assign eth1 to "lan".
...

Maybe I am introducing an isse I am overlooking here, but I would like to point out that in ar71xx the setup is as follows:

root at OpenWrt:~# brctl show
bridge name     bridge id               STP enabled     interfaces
br-lan          7fff.18d6c796aaed       no              eth1
                                                         eth0.1

And personally I would not like to change how things work.

Adrian:
> phy0tpt trigger can be moved to DTS, just have a look at other devices recently added to ath79
I will, thank you! But if this is going to disallow users from easily changing how the LED is used, I would rather avoid that.
Let me try this out!

Adrian said:
> I would remove the ".0" here, as with TP-Link the sub-revisions typically refer only to their firmware. So just "v1" should be better.
Thanks!

Adrian:
> What's that?
I copied those from ar71xx C implementation, since I tought there was a reason why Filip put them here.
And, in general, I tought they may aid debugging / help newcomers to explore the device further.

Adrian:
> IMO those labels only make sense if you use them, as for led_power. I would remove all of the other ones, i.e. only "wan {" here instead of "led_wan: wan {" ...
Thanks!

Adrian:
> Sure about the 0?
Ok, I'll transition to gpio-hogg. My intention is to leave this available in user-space.
I used the .0 here due to the following line in the C implementation file:
gpio_request_one(TL_MR6400_GPIO_LTE_POWER,
 	GPIOF_OUT_INIT_LOW | GPIOF_EXPORT_DIR_FIXED | GPIOF_ACTIVE_LOW,
 	"LTE power");

and in particular the GPIOF_OUT_INIT_LOW; with this setup the device powers on the LTE modem at startup.
Any particular advice when using gpio-hogg?

Adrian:
> There is a tab between uboot and partition. Replace by space ...
Thanks!

> You can remove kmod-usb-core, kmod-usb-net and kmod-usb-serial, as those are dependencies of the other packages.
Thank you very much.

Filip:
> Anyway good job Enrico.
Thanks man!!!!! And thank you again for your work in supporting this nice device!

Filip:
> When you face MR6400's ethernet ports to you the port order is from left to right:

Thank you very very much! I'll test ASAP.

Thank you also for the testing you plan to do.
I plan to sort out ethernet issues, then address all the other problems (e.g.: switch to gpio-hog and so on).
When I'll have sighted assistance I'll check LEDs and recovery as well. :)

Adrian:
> Maybe you need phy-swap? I try to have a look later during the week.
Precious hint! Thanks!!



Enrico

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel