[OpenWrt-Devel] [PATCH] Support for Edimax EW-7476RPC

[Cezary Jackiewicz]

Dnia 2019-05-25, o godz. 09:30:29
Birger Koblitz <mail at birger-koblitz.de> napisał(a):

Hi,

> The model is also compatible with the newer EW-7478AC, at least the 
> firmware can be cross-flashed after changing the magic bytes at the 
> beginning of the image from RN79 to RN70. The newer device merely has 
> external antennas.

Could you also add support for EW-7478AC? I can test it.
See my comments below.

> +       compatible = "edimax,ew-7476rpc", "ralink,mt7620a-soc";
> +       model = "Edimax EW7476RPC";

Should be "Edimax EW-7476RPC";

> +                };
> +       };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               led_power: power {
> +                       label = "ew-7476rpc:green:power";
> +                       gpios = <&gpio2 27 GPIO_ACTIVE_LOW>;
> +               };
> +               internet {
> +                       label = "ew-7476rpc:green:internet";
> +                       gpios = <&gpio2 26 GPIO_ACTIVE_LOW>;
> +               };
> +               wlan2g {
> +                       label = "ew-7476rpc:blue:wlan2g";
> +                       gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
> +                       linux,default-trigger = "phy1tpt";
> +               };
> +               wlan5g {
> +            label = "ew-7476rpc:blue:wlan5g";
> +            gpios = <&gpio2 31 GPIO_ACTIVE_LOW>;
> +            linux,default-trigger = "phy0tpt";

Missing indentation?


> +
> +/*
> +       gpio_export {
> +               compatible = "gpio-export";
> +               #size-cells = <0>;
> +               usb-power {
> +                       gpio-export,name="usb-power";
> +                       gpio-export,output=<1>;
> +                       gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
> +               };
> +       };
> +       */

Remove comment.


> +
> +&gsw {
> +       mediatek,port5 = "gmac";
> +       mediatek,rtl8211e-reset = "yes";

Or better use mediatek,rtl8211e-reset = <1>;

> 
> +        pr_info("gsw: mt7620_hw_init: mdio_mode set, disabling ephy\n");

unnecessary comment

>          struct platform_device *pdev = of_find_device_by_node(np);
>          struct mt7620_gsw *gsw;
> +    const char *rtl8211e_reset = NULL;
...
> -
> +    of_property_read_string(np, "mediatek,rtl8211e-reset", 
> &rtl8211e_reset);
> +    if (rtl8211e_reset && !strcmp(rtl8211e_reset, "yes"))
> +        reset_realtek_phy();

of_get_property(np, "mediatek,rtl8211e-reset", NULL) etc.


> +        append-metadata | check-size $$$$(IMAGE_SIZE)
> +  DEVICE_PACKAGES := kmod-mt76x2 kmod-usb2 kmod-usb-ohci kmod-phy-realtek

Edimax EW-7476RPC has USB port? Drop kmod-usb2 and kmod-usb-ohci package.


-- 
Pozdrawiam,
 Cezary Jackiewicz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel