[OpenWrt-Devel] [PATCH 01/11] tools/libaio: new package

[Thomas Petazzoni]

Hello Hauke,

Thanks for the review!

On Mon, 25 Mar 2019 18:13:50 +0100
Hauke Mehrtens <hauke at hauke-m.de> wrote:

> On 3/11/19 5:20 PM, Thomas Petazzoni wrote:
> > From: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>  
> 
> Does this email address still exists?

It does exist and work, but I'm not supposed to use it. I'll fix this
up, there was some old .gitconfig lying around.

> > diff --git a/tools/Makefile b/tools/Makefile
> > index 9a354f6c70..9702b4df25 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -27,6 +27,7 @@ tools-y += sstrip make-ext4fs e2fsprogs mtd-utils mkimage
> >  tools-y += firmware-utils patch-image quilt padjffs2
> >  tools-y += mm-macros missing-macros cmake scons bc findutils gengetopt patchelf
> >  tools-y += mtools dosfstools libressl
> > +tools-y += libaio  
> 
> I would prefer if this only gets build when
> CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED is set or some other config variable.

Sure. I was a bit confused by this to be honest. Wouldn't it be
possible to just add "cryptsetup" to tools-y when
CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED=y, and have the other packages
(libaio, popt, lvm2) be simply built as dependencies of cryptsetup ?

Indeed, what CONFIG_TARGET_ROOTFS_SQUASHFS_HASHED=y really needs is
cryptsetup, the rest are mere build dependencies to build cryptsetup.

> > +PKG_NAME:=libaio
> > +PKG_VERSION:=0.3.111
> > +PKG_HASH:=62cf871ad8fd09eb3418f00aca7a7d449299b8e1de31c65f28bf6a2ef1fa502a
> > +PKG_RELEASE:=1
> > +
> > +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
> > +PKG_SOURCE_URL:=https://releases.pagure.org/libaio
> > +
> > +HOST_BUILD_PARALLEL:=1
> > +
> > +include $(INCLUDE_DIR)/host-build.mk
> > +
> > +define Host/Configure
> > +endef  
> 
> Is this empty configure section needed?

Meh, most likely not. Will fix and retest.

Again, thanks for the review, much appreciated!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel