[OpenWrt-Devel] [PATCH] ramips: mt7621: Add new device AsiaRF AP7621-001

[Daniel Danzberger]

I see. I will change the model property then...

On 6/25/19 10:39 AM, Petr Štetiar wrote:
> Daniel Danzberger <daniel at dd-wrt.com> [2019-06-25 10:34:47]:
> 
>>>> +	model = "AP7621-001";
>>>
>>> Oh boy, this is tricky.
>>>
>>> <https://github.com/devicetree-org/devicetree-specification/blob/4b1dac80eaca45b4babf5299452a951008a5d864/source/devicenodes.rst>
>>> 'The recommended format ' (for the root node!) ' is "manufacturer,model-number".'
>>>
>>> BUT. Thing is, this string here gets printed on the LuCI system
>>> page and from past experience "Manugacturer Model" works best.
>>>
>> I am not sure if using a blank instead of ',' is a good idea, because of
>> sysupgrade and the device tree board detection.
>> All other DTS files use ',' in DTS and '_' in their Makefile.
>>
>> Are you sure about this one ?
> 
> Yes, Christian is talking about model property, not the compatible property.
> 
>  model = "AsiaRF AP7621-001";
> 
> -- ynezz
> 

-- 
Regards

Daniel Danzberger
embeDD GmbH, Alter Postplatz 2, CH-6370 Stans

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel