[OpenWrt-Devel] [PATCH opkg] alternatives: special-case busybox as alternatives provider

[Yousong Zhou]

On Thu, 13 Jun 2019 at 20:45, Jo-Philipp Wich <jo at mein.io> wrote:
>
> Hi,
>
> ACK on the patch. I was thinking about whether it makes sense to move out
> the hardcoded package "busybox" -> "/bin/busybox" path facts into some kind
> of external pkgname => multicall-executable-path mapping configuration but
> there's probably not that many other relevant packages where this would apply.
>
> Still I'd like to see the code somewhat generalized... rename the
> "pkg_alternatives_check_busybox()" procedure to something like
> "pkg_alternatives_find_fallback()" and have it iterate an array of
> "struct { char *pkgname; char *multicallpath; }" which may initially contain
> just { { "busybox", "/bin/busybox" }, }.

I also thought about this but refrained from going that path ;)   Will
send v2 for review.

Regards,
                yousong

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel