[OpenWrt-Devel] [PATCH] ramips: add support for Edimax EW-7476RPC / EW-7478AC

[Petr Štetiar]

Birger Koblitz <mail at birger-koblitz.de> [2019-06-03 19:04:23]:

> +		phy0: ethernet-phy at 0 {
> +			status ="disabled";

missing space after = and you've just copy&pasted it to the second file.

> +			status = "disabled";
> +			reg = <4>;
> +			phy-mode = "rgmii";
> +		};
> +	};
> +};
> +
> +

remove the extra new line here.

> +&gsw {
> +	mediatek,port5 = "gmac";
> +};
> +
> +

here as well.

> +			label = "ew-7478ac:blue:wlan2g";
> +			linux,default-trigger = "phy1radio";
> +
> +			label = "ew-7478ac:blue:wlan5g";
> +			linux,default-trigger = "phy0radio";

it makes me wonder what's wrong with the phy0tpt/phy1tpt throughput based and
defacto default triggers.

> +	if(!phy_reset)
> +		return;

ERROR: space required before the open parenthesis '('
#567: FILE:
target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c:1346:
+	if(!phy_reset)

> +	if (IS_ERR(phy_reset)){

ERROR: space required before the open brace '{'
#570: FILE:
target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/mtk_eth_soc.c:1349:
+	if (IS_ERR(phy_reset)){

> +		dev_err(priv->dev, "Error acquiring reset gpio pins: %ld\n",
> +			PTR_ERR(phy_reset));
> +		return;
> +	}

new line here please.

> +	err = of_property_read_u32(priv->dev->of_node, "phy-reset-duration",
> +				   &msec);
> +	if (!err && msec > 1000)
> +		msec = 30;
> +
> +	mdelay(msec);