[OpenWrt-Devel] RE：RE: [PATCH] ramips: add support to JS7628 development board

[Adrian Schmutzler]

Hi,

 

I had a look at u7628-01-128m-16m .

 

You are right that this case is similar to your example, but I also think that it should be renamed, too.

 

There are other examples in mt7628an using only flash size for name distinction, e.g.

mt7628an_widora_neo-16m

mt7628an_widora_neo-32m

 

In mt7621, we recently added auto-detection and even did rename devices with different memory sizes there:

https://github.com/openwrt/openwrt/commit/087e14ab5994986802739b57e2de227760102bf4

 

So, one definition will be available for all (auto-detected) memory sizes.

 

So, I would call your devices:

zhuotk,js7628-8m

zhuotk,js7628-16m

zhuotk,js7628-32m

 

model = "ZhuoTK JS7628 (8M flash)"

etc.

 

define Device/zhuotk_js7628-8m

etc.

 

DEVICE_VARIANT := 8M

etc.

 

Despite, is there a reason why call common DTSI and compatible “zhuotk,js76x8” and not “zhuotk,js7628”?

 

And I still do not see the reason for

SUPPORTED_DEVICES += js7628-8m-64m js7688-8m-64m ztk7628p-8m-64m

or do you have OpenWrt-based firmware with those strings installed previously?

 

Best

 

Adrian Schmutzler

 

 

From: 且听风吟 [mailto:wurobinson at qq.com] 
Sent: Dienstag, 30. Juli 2019 07:50
To: Adrian Schmutzler <mail at adrianschmutzler.de>
Cc: openwrt-devel <openwrt-devel at lists.openwrt.org>
Subject: RE：RE: [OpenWrt-Devel] [PATCH] ramips: add support to JS7628 development board

 

Hi Adrian,

    Before I did this commit, I referred to "mt7628an_unielec_u7628-01-128m-16m.dts". Yes, I use the memory auto-detected function. Will you help me to modiy information concerning RAM size? Or if you have more advices, you can tell me, so I can modify them in the next commit.

 

Best

Robinson wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190730/b0e9c1ee/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190730/b0e9c1ee/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel