[OpenWrt-Devel] [PATCH] libevent2: Add -Wl, --gc-sections to reduce size a little.

[Rosen Penev]

On Tue, Feb 19, 2019 at 10:19 PM Petr Štetiar <ynezz at true.cz> wrote:
>
> Rosen Penev <rosenp at gmail.com> [2019-02-19 13:01:57]:
>
> > -TARGET_CFLAGS += $(FPIC)
>
> Why did you removed this? I can see, that you've added --with-pic configure
> option, but I'm wondering if it's going to provide same result on all
> platforms.
Don't see why not. it adds fPIC and dPIC
>
> > +TARGET_LDFLAGS += -Wl,--gc-sections
>
> I'm not sure whether this is a good idea on library, or is it?
Doesn't have any negative effects on other packages from what I've seen.
>
> > +     --disable-libevent-regress \
>
> I'm wondering how this might reduce the binary size. It might be enabled by
> default for some reason, so I'm not sure if disabling regression tests for
> saving some build time (BTW how much?) is a good idea.
Seems to also be done elsewhere.
>
> You've forget to add on which platforms you've build and run tested this
> change, and mainly on which platform you're seeing this 4KB size reduction.
ramips. I doubt it's much different elsewhere.
>
> -- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel