[OpenWrt-Devel] [PATCH] [ubox] kmodloader: increase module name length

Sergiy Kibrik sakib at darkstar.site
Mon Feb 18 12:38:49 EST 2019


hi Bjørn,

On 2/18/19 4:24 PM, Bjørn Mork wrote:
> Agreed that 33 is not enough, but NAME_MAX is way overkill again.  Why
> not use the actual max length from the kernel?:
> 
>  include/linux/module.h:#define MODULE_NAME_LEN MAX_PARAM_PREFIX_LEN
>  include/linux/moduleparam.h:#define MAX_PARAM_PREFIX_LEN (64 - sizeof(unsigned long))

but those aren't exposed to user space.
Or do you suggest to duplicate that (64 - sizeof(unsigned long)) definition?

--
regards,
Sergiy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 321 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190218/f34fe2ee/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list