[OpenWrt-Devel] [PATCH 2/2] ath79: GL.iNet AR300M family: Correct DTS LED definitions

[Szabolcs Hubai]

Jeff Kletsky <lede at allycomm.com> ezt írta (időpont: 2019. febr. 6., Sze, 2:25):
>
>
> On 2/5/19 4:19 PM, Szabolcs Hubai wrote:
> > Hi Jeff,
> >
> > sorry for being late in the topic, but that [1] red "status" LED is
> > GL-AR300M-Lite specific, and isn't suitable for the original GL-AR300M
> > model, IMHO.
> >
> >
> > Here are my points:
> >
> > I opened my GL-AR300MD's case (a limited, dualband model), and it has
> > a "GL-AR300M-V1.3.1" print on it's PCB.
> > It has the exactly same pinouts as it could be seen on the
> > documentation page [2] (picture attached) and it's WLAN LED is red,
> > the other two, LAN and SYS (in DTS: "status") are green.
> >
> > I'm unsure how are the LED colors in the other GL-AR300M sub-models.
> >
> I checked the GL.iNet site and the video of the GL-AR300M at
> <https://docs.gl-inet.com/en/2/hardware/ar300m/#debrick>
> published in January, 2017, shows two green and a red LED,
> consistent with your description.
>
> On the other hand, GL.iNet's source shows them as all "green"
> (as is the AR300M-Lite I have in hand)
>
> <https://github.com/gl-inet/openwrt/blob/develop/target/linux/ar71xx/files/arch/mips/ath79/mach-gl-ar300m.c#L49>
>
> I'm fine with leaving the color alone or being consistent with current
> production
> and the OEM's definitions. Shoot, my Archer C7 v2 has "blue" LEDs under
> OpenWrt.
> Too bad that doesn't actually change the color of them ;)
>
> The GPIO assignments are still in need of correction, as far as I can
> tell, for all variants.
>
>
> Jeff
>
>

My GL-AR300MD is pretty old, I bought it when that debrick video was created. :)

It would be nice, that you could introduce the Lite support with red
"status" LED color.
And the GL-AR300M model "status" LED should have at least a comment
about this inconsistency to avoid the "fixes" to change it back and
forth.
It is also possible that the newly produced versions of GL-AR300M (not
just the -Lite edition) has the new colors.


Yup, the GPIO change was correct.



Szabolcs

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel