[OpenWrt-Devel] [PATCH v2 ubus] ubusd/libubus-io: fix socket descriptor passing

Hannu Nyman hannu.nyman at welho.com
Fri Dec 27 09:44:39 EST 2019


Petr Štetiar kirjoitti 27.12.2019 klo 16.15:
> In commit 5d7ca8309d0a ("ubusd/libubus-io: fix variable sized struct
> position warning") the position of cmsghdr struct has been changed in
> order to fix clang-9 compiler warning, but it has introduced regression
> in at least `logread` which hanged indefinitely.
>
> So this patch reworks the socket descriptor passing in a way recommended
> in the `cmsg(3)` manual page.
>
> Ref: http://lists.infradead.org/pipermail/openwrt-devel/2019-December/020840.html
> Fixes: 5d7ca8309d0a ("ubusd/libubus-io: fix variable sized struct position warning")
> Reported-by: Hannu Nyman <hannu.nyman at welho.com>
> Signed-off-by: Petr Štetiar <ynezz at true.cz>
> ---

That seems to take care of the logread problem. Thanks.

But neither collectd not nlbwmon starts. They are still broken with the 
current ubus.


Looking now at the (again working) system log reveals:

root at router2:~# logread | grep collectd
Fri Dec 27 16:23:37 2019 daemon.info procd: Not starting instance 
collectd::instance1, command not set
root at router2:~# logread | grep nlbwmon
Fri Dec 27 16:23:33 2019 daemon.info procd: Not starting instance 
nlbwmon::instance1, command not set



_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list