[OpenWrt-Devel] [PATCH] use strncpy instead of strcpy

[Paul Fertser]

Hi,

On Tue, Dec 24, 2019 at 10:02:13AM -0800, Khem Raj wrote:
> +	hdr->name[strlen((char*)hdr->name)] = '\0';
> +	strncpy((char *) hdr->name, (const char *)name, strlen((char*)hdr->name));

strlen((char*)hdr->name) doesn't seem to be meaningful in this
context, are you sure you were not meaning to do something like this instead?

+	strncpy((char *) hdr->name, (const char *)name, sizeof(hdr->name));
+	hdr->name[sizeof(hdr->name) - 1] = '\0';

-- 
Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
mailto:fercerpav at gmail.com

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel