[OpenWrt-Devel] [PATCH ubus 15/16] ubus_monitor: workaround possibly false positive uses of memory after it is freed

Petr Štetiar ynezz at true.cz
Thu Dec 19 17:11:24 EST 2019


scan-build from clang-9 has reported following:

 libubox/list.h:141:2: warning: Use of memory after it is freed
        _list_add(_new, head, head->next);

Signed-off-by: Petr Štetiar <ynezz at true.cz>
---
 ubusd_monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ubusd_monitor.c b/ubusd_monitor.c
index 501e06d0716c..bba741e86987 100644
--- a/ubusd_monitor.c
+++ b/ubusd_monitor.c
@@ -41,7 +41,7 @@ ubusd_monitor_connect(struct ubus_client *cl, struct ubus_msg_buf *ub)
 		return false;
 
 	m->cl = cl;
-	list_add(&m->list, &monitors);
+	list_add_tail(&m->list, &monitors);
 
 	return true;
 }

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list