[OpenWrt-Devel] [PATCH] ath79: add support for Ubiquiti LiteBeam AC Gen2

Petr Štetiar ynezz at true.cz
Tue Dec 3 07:09:30 EST 2019


Hi,

> > I used the same as with other ubnt-wa devices. I'm not really up to date
> > on this metadata thing. Do we normally not include it in factory images?

Indeed, but you've added following extra line to your device:

 IMAGE/factory.bin := $$(IMAGE/sysupgrade.bin) | mkubntimage-split

Which means, that you're constructing factory image from sysupgrade image, and
sysupgrade images have this metadata included. I would just drop this line.

> I'm also not sure whether we need the append-metadata, thus I wouldn't
> deviate from the other ubnt-wa devices.

I'm sure, that there is no need for this deviation from other ubnt-wa devices.

-- ynezz

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel



More information about the openwrt-devel mailing list