[OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget

[mail at adrianschmutzler.de]

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces at lists.openwrt.org]
> On Behalf Of Paul Spooren
> Sent: Donnerstag, 22. August 2019 21:07
> To: John Crispin <john at phrozen.org>; openwrt-devel at lists.openwrt.org
> Subject: Re: [OpenWrt-Devel] [PATCH] ipqx0xx: add Generic subtarget
> 
> 
> On 22.08.19 00:11, John Crispin wrote:
> >
> > On 22/08/2019 08:47, Paul Spooren wrote:
> >> Hi John,
> >>> This commit adds the Generic subtarget resulting in consistent naming.
> >>
> >> and
> >>
> >>> already uses `x/generic/` as subfolder as if the subtarget would exist.
> >>
> >> I'm very much in favor of consistent names[0][1][2] as it reduces the
> >> hassle when trying automate things, like building images via an API[3].
> >>
> >> Is the subtarget causing any harm except for eight additional
> >> characters per filename?
> >>
> >> Paul
> >>
> >> [0]: https://github.com/openwrt/openwrt/pull/2330
> >> [1]: https://github.com/openwrt/openwrt/pull/2334
> >> [2]: https://github.com/openwrt/openwrt/pull/2326
> >> [3]: https://github.com/aparcar/attendedsysupgrade-server
> >>
> > dont really care, just wondering why
> 
> If you don't mind please merge it, I think it's the last target without a defined
> subtarget.
> 
> Paul
> 

Just to back Paul up, I also think this will be helpful, as we just have one special case to deal with (i.e. targets without subtarget) less and it doesn't hurt much.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190822/8926f86b/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel