[OpenWrt-Devel] [PATCH] ramips: add support for Xiaomi Mi Wi-Fi Router 3G v2

[mail at adrianschmutzler.de]

Hi,

> > > +  DEVICE_MODEL := Mi router 3G v2
> >
> > Capitalize "router". Despite, use DEVICE_VARIANT, so:
> >
> > +  DEVICE_MODEL := Mi Router 3G
> > +  DEVICE_VARIANT := v2
> >
> > > +  SUPPORTED_DEVICES += mir3gv2
> >
> > Drop this line.
> 
> So apparently this "v2" is in fact an _officially_ relabled "Xiaomi Mi Router 4A
> Gigabit Edition (R4AG/R4A Gigabit)", according to the reports from [1] and
> the related thread on "4pda.ru" forum. Insane, yes.
> 
> What course of actions would you recommend in this case?

Well, you essentially have two options then:

You could just add the new image anyway, if device names are different and there is a chance for taking the wrong image (i.e. mir3g because there is no v2), this is generally reasonable.

If the devices really are 100 % similar, you might instead want to exploit the syntax introduced in https://github.com/openwrt/openwrt/pull/2250 and just add
DEVICE_ALT0_VENDOR := Xiaomi
DEVICE_ALT0_MODEL := Mi Router 3G
DEVICE_ALT0_VARIANT := v2
to the existing configuration of the "Xiaomi Mi Router 4A Gigabit Edition (R4AG/R4A Gigabit)" (without adding a new device).

The second approach would have the advantage that you do not need to create the same image twice.
The disadvantage would be that the new name is only available in "make menuconfig" etc., i.e. when you build the image, but you won't get an additional image file with the new name.
Despite, the PR is already waiting for a long time, so this might additionally prolong your waiting (although device support typically has long waiting, too).

Since there is a "v1" for the mir3g, I personally would go for option 1 and just keep what you did so far.

Unless I misunderstood something, this has nothing to do with SUPPORTED_DEVICES which should be removed, unless Xiaomi ships an OpenWrt distro as vendor firmware.

Best

Adrian



> 
> TIA
> 
> [1] https://forum.openwrt.org/t/xiaomi-mi-router-4a-gigabit-edition-r4ag-
> r4a-gigabit-fully-supported-but-requires-overwriting-spi-flash-with-
> programmer/36685/41
> 
> --
> Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
> mailto:fercerpav at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190822/7653e7a3/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel